remoting/webapp/app_remoting/js/app_remoting.js - Issue 1067133002: Move ProtocolExtensionManager from SessionConnector into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 1067133002: Move ProtocolExtensionManager from SessionConnector into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/remoting_webapp_files.gypi ('k') | remoting/webapp/base/js/protocol_extension_manager.js » ('j') | remoting/webapp/base/js/protocol_extension_manager_unittest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/app_remoting/js/app_remoting.js

diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js

index 3e7c031d670f9c7b81606ab14a5f9dd78b29910d..c0630c792a5ba6dc9773c9a35f16212f0a2697bd 100644

--- a/remoting/webapp/app_remoting/js/app_remoting.js

+++ b/remoting/webapp/app_remoting/js/app_remoting.js

@@ -214,7 +214,7 @@ remoting.AppRemoting.prototype.onConnected_ = function(connectionInfo) {

JSON.stringify({fullName: userInfo.name}));

});

- this.sessionConnector_.registerProtocolExtension(this);

+ connectionInfo.plugin().extensions().register(this);

this.connectedView_ = new remoting.AppConnectedView(

document.getElementById('client-container'), connectionInfo);