chrome/browser/content_settings/tab_specific_content_settings.h - Issue 106713004: Remove kEnableResourceContentSettings and all the code that uses it since it's been behind a flag f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 106713004: Remove kEnableResourceContentSettings and all the code that uses it since it's been behind a flag f… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/content_settings/tab_specific_content_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/tab_specific_content_settings.h

===================================================================

--- chrome/browser/content_settings/tab_specific_content_settings.h (revision 239622)

+++ chrome/browser/content_settings/tab_specific_content_settings.h (working copy)

@@ -294,8 +294,7 @@

bool blocked_by_policy) OVERRIDE;

// Message handlers. Public for testing.

- void OnContentBlocked(ContentSettingsType type,

- const std::string& resource_identifier);

Bernhard Bauer 2013/12/10 23:14:05 I'm wondering if we should keep the resource ident

jam 2013/12/11 00:15:38 my philosophy is if we want to expose it, let's ad

+ void OnContentBlocked(ContentSettingsType type);

void OnContentAllowed(ContentSettingsType type);

// These methods are invoked on the UI thread by the static functions above.

@@ -351,9 +350,6 @@

explicit TabSpecificContentSettings(content::WebContents* tab);

friend class content::WebContentsUserData<TabSpecificContentSettings>;

- void AddBlockedResource(ContentSettingsType content_type,

- const std::string& resource_identifier);

// content::NotificationObserver implementation.

virtual void Observe(int type,

const content::NotificationSource& source,