chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 106713002: Move LaunchContainer enum to extension_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 106713002: Move LaunchContainer enum to extension_constants.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc ('k') | chrome/test/remoting/remote_desktop_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 065bebca62ad4632c4bb6408e60237785f587f9c..084b9ec40ab13c04dafee22fb031a4371b0f2940 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -17,7 +17,7 @@ TEST_F(ValidAppManifestTest, ValidApp) {

AddPattern(&expected_patterns, "http://www.google.com/mail/*");

AddPattern(&expected_patterns, "http://www.google.com/foobar/*");

EXPECT_EQ(expected_patterns, extension->web_extent());

- EXPECT_EQ(extensions::LAUNCH_TAB,

+ EXPECT_EQ(extensions::LAUNCH_CONTAINER_TAB,

extensions::AppLaunchInfo::GetLaunchContainer(extension.get()));

EXPECT_EQ(GURL("http://www.google.com/mail/"),

extensions::AppLaunchInfo::GetLaunchWebURL(extension.get()));