chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc - Issue 106713002: Move LaunchContainer enum to extension_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

Issue 106713002: Move LaunchContainer enum to extension_constants.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/app_launch_info.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

index 0279d369fe40d5ec00c94897d65a2238aee1ff70..6912dace7acb62b0ae37a0d965c66f7a44f7f0ed 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

@@ -23,13 +23,16 @@ TEST_F(AppLaunchManifestTest, AppLaunchContainer) {

scoped_refptr<Extension> extension;

extension = LoadAndExpectSuccess("launch_tab.json");

- EXPECT_EQ(LAUNCH_TAB, AppLaunchInfo::GetLaunchContainer(extension.get()));

+ EXPECT_EQ(LAUNCH_CONTAINER_TAB,

+ AppLaunchInfo::GetLaunchContainer(extension.get()));

extension = LoadAndExpectSuccess("launch_panel.json");

- EXPECT_EQ(LAUNCH_PANEL, AppLaunchInfo::GetLaunchContainer(extension.get()));

+ EXPECT_EQ(LAUNCH_CONTAINER_PANEL,

+ AppLaunchInfo::GetLaunchContainer(extension.get()));

extension = LoadAndExpectSuccess("launch_default.json");

- EXPECT_EQ(LAUNCH_TAB, AppLaunchInfo::GetLaunchContainer(extension.get()));

+ EXPECT_EQ(LAUNCH_CONTAINER_TAB,

+ AppLaunchInfo::GetLaunchContainer(extension.get()));

extension = LoadAndExpectSuccess("launch_width.json");

EXPECT_EQ(640, AppLaunchInfo::GetLaunchWidth(extension.get()));