Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6031)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 106713002: Move LaunchContainer enum to extension_constants.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index 3ba748fb0d40db6369cd1f8beeda93cc5e94ec77..2da8b9b1b4c7aa50b2cae9232ace47544c1dfe19 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -209,7 +209,7 @@ LOG(ERROR) << app_id;
if (!extensions::HasPreferredLaunchContainer(
extensions_service->extension_prefs(), extension))
- launch_container = extensions::LAUNCH_WINDOW;
+ launch_container = extensions::LAUNCH_CONTAINER_WINDOW;
*out_extension = extension;
*out_launch_container = launch_container;
@@ -371,7 +371,7 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,
if (extension) {
RecordCmdLineAppHistogram(extensions::Manifest::TYPE_PLATFORM_APP);
AppLaunchParams params(profile, extension,
- extensions::LAUNCH_NONE, NEW_WINDOW);
+ extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW);
params.command_line = &command_line_;
params.current_directory = cur_dir_;
OpenApplicationWithReenablePrompt(params);
@@ -482,13 +482,14 @@ bool StartupBrowserCreatorImpl::OpenApplicationTab(Profile* profile) {
return false;
// If the user doesn't want to open a tab, fail.
- if (launch_container != extensions::LAUNCH_TAB)
+ if (launch_container != extensions::LAUNCH_CONTAINER_TAB)
return false;
RecordCmdLineAppHistogram(extension->GetType());
WebContents* app_tab = OpenApplication(AppLaunchParams(
- profile, extension, extensions::LAUNCH_TAB, NEW_FOREGROUND_TAB));
+ profile, extension, extensions::LAUNCH_CONTAINER_TAB,
+ NEW_FOREGROUND_TAB));
return (app_tab != NULL);
}
@@ -517,7 +518,7 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(
// and avoid calling GetAppLaunchContainer() both here and in
// OpenApplicationTab().
- if (launch_container == extensions::LAUNCH_TAB)
+ if (launch_container == extensions::LAUNCH_CONTAINER_TAB)
return false;
RecordCmdLineAppHistogram(extension->GetType());

Powered by Google App Engine
This is Rietveld 408576698