Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

Issue 106713002: Move LaunchContainer enum to extension_constants.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/common/chrome_switches.h" 6 #include "chrome/common/chrome_switches.h"
7 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 7 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
9 #include "extensions/common/error_utils.h" 9 #include "extensions/common/error_utils.h"
10 #include "extensions/common/extension.h" 10 #include "extensions/common/extension.h"
11 #include "extensions/common/manifest_constants.h" 11 #include "extensions/common/manifest_constants.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 namespace errors = manifest_errors; 16 namespace errors = manifest_errors;
17 namespace keys = manifest_keys; 17 namespace keys = manifest_keys;
18 18
19 class AppLaunchManifestTest : public ExtensionManifestTest { 19 class AppLaunchManifestTest : public ExtensionManifestTest {
20 }; 20 };
21 21
22 TEST_F(AppLaunchManifestTest, AppLaunchContainer) { 22 TEST_F(AppLaunchManifestTest, AppLaunchContainer) {
23 scoped_refptr<Extension> extension; 23 scoped_refptr<Extension> extension;
24 24
25 extension = LoadAndExpectSuccess("launch_tab.json"); 25 extension = LoadAndExpectSuccess("launch_tab.json");
26 EXPECT_EQ(LAUNCH_TAB, AppLaunchInfo::GetLaunchContainer(extension.get())); 26 EXPECT_EQ(LAUNCH_CONTAINER_TAB,
27 AppLaunchInfo::GetLaunchContainer(extension.get()));
27 28
28 extension = LoadAndExpectSuccess("launch_panel.json"); 29 extension = LoadAndExpectSuccess("launch_panel.json");
29 EXPECT_EQ(LAUNCH_PANEL, AppLaunchInfo::GetLaunchContainer(extension.get())); 30 EXPECT_EQ(LAUNCH_CONTAINER_PANEL,
31 AppLaunchInfo::GetLaunchContainer(extension.get()));
30 32
31 extension = LoadAndExpectSuccess("launch_default.json"); 33 extension = LoadAndExpectSuccess("launch_default.json");
32 EXPECT_EQ(LAUNCH_TAB, AppLaunchInfo::GetLaunchContainer(extension.get())); 34 EXPECT_EQ(LAUNCH_CONTAINER_TAB,
35 AppLaunchInfo::GetLaunchContainer(extension.get()));
33 36
34 extension = LoadAndExpectSuccess("launch_width.json"); 37 extension = LoadAndExpectSuccess("launch_width.json");
35 EXPECT_EQ(640, AppLaunchInfo::GetLaunchWidth(extension.get())); 38 EXPECT_EQ(640, AppLaunchInfo::GetLaunchWidth(extension.get()));
36 39
37 extension = LoadAndExpectSuccess("launch_height.json"); 40 extension = LoadAndExpectSuccess("launch_height.json");
38 EXPECT_EQ(480, AppLaunchInfo::GetLaunchHeight(extension.get())); 41 EXPECT_EQ(480, AppLaunchInfo::GetLaunchHeight(extension.get()));
39 42
40 Testcase testcases[] = { 43 Testcase testcases[] = {
41 Testcase("launch_window.json", errors::kInvalidLaunchContainer), 44 Testcase("launch_window.json", errors::kInvalidLaunchContainer),
42 Testcase("launch_container_invalid_type.json", 45 Testcase("launch_container_invalid_type.json",
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 123
121 extension = LoadAndExpectSuccess("launch_web_url_absolute.json"); 124 extension = LoadAndExpectSuccess("launch_web_url_absolute.json");
122 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 125 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
123 AppLaunchInfo::GetFullLaunchURL(extension.get())); 126 AppLaunchInfo::GetFullLaunchURL(extension.get()));
124 extension = LoadAndExpectSuccess("launch_web_url_localized.json"); 127 extension = LoadAndExpectSuccess("launch_web_url_localized.json");
125 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 128 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
126 AppLaunchInfo::GetFullLaunchURL(extension.get())); 129 AppLaunchInfo::GetFullLaunchURL(extension.get()));
127 } 130 }
128 131
129 } // namespace extensions 132 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698