Reland: Add an event to notify accessibility when a permissions bubble gets shown.

Reland: Add an event to notify accessibility when a permissions bubble gets shown.

BUG=381338, 474622
TEST=ctrl+alt+z; navigate to html5demos.com/geo; observe speech is as expected (reads contents of bubble).

Committed: https://crrev.com/36318aa45e02cf0b5cf871bf38bbe47f3431cc8d
Cr-Commit-Position: refs/heads/master@{#323982}

Committed: https://crrev.com/6fec1d1629494b9f3995e987435eb3150e2d8822
Cr-Commit-Position: refs/heads/master@{#324148}

[David Tseng, 2015-04-07 21:21:23]

dtseng@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2015-04-07 21:36:06]

Sorry for all this fuss to just add an explanatory comment; lgtm with a comment
suggestion.

https://codereview.chromium.org/1067113002/diff/1/ui/views/bubble/bubble_dele...
File ui/views/bubble/bubble_delegate.h (right):

https://codereview.chromium.org/1067113002/diff/1/ui/views/bubble/bubble_dele...
ui/views/bubble/bubble_delegate.h:25: // Note for those adding subclasses, to
have your view read in its entirety by
You can leave this comment with the NotifyAccessibilityEvent block in the
HandleVisibilityChanged impl. Consider rephrasing the comment to something like:
"Fire AX_EVENT_ALERT for bubbles marked as AX_ROLE_ALERT_DIALOG; this instructs
accessibility tools to read the bubble in its entirety, rather than just its
title and initially focused view. See http://crbug.com/474622 for details."

[David Tseng, 2015-04-07 21:50:53]

https://codereview.chromium.org/1067113002/diff/1/ui/views/bubble/bubble_dele...
File ui/views/bubble/bubble_delegate.h (right):

https://codereview.chromium.org/1067113002/diff/1/ui/views/bubble/bubble_dele...
ui/views/bubble/bubble_delegate.h:25: // Note for those adding subclasses, to
have your view read in its entirety by
On 2015/04/07 21:36:06, msw wrote:
> You can leave this comment with the NotifyAccessibilityEvent block in the
> HandleVisibilityChanged impl. Consider rephrasing the comment to something
like:
> "Fire AX_EVENT_ALERT for bubbles marked as AX_ROLE_ALERT_DIALOG; this
instructs
> accessibility tools to read the bubble in its entirety, rather than just its
> title and initially focused view. See http://crbug.com/474622 for details."

Done.

[msw, 2015-04-07 21:54:27]

lgtm, thanks

[David Tseng, 2015-04-07 22:00:11]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2015-04-07 22:00:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067113002/20001

[commit-bot: I haz the power, 2015-04-07 23:06:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 23:07:17]

Patchset 2 (id:??) landed as
https://crrev.com/6fec1d1629494b9f3995e987435eb3150e2d8822
Cr-Commit-Position: refs/heads/master@{#324148}