Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1067093002: Don't define timespec in VS 2015 builds. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't define timespec in VS 2015 builds. VS 2015 includes time.h from stdlib.h which leads to redefinition warnings when threads_windows.h defines the timespec struct. Ideally threads_windows.h shouldn't be defining CRT structs at all, but I am doing the minimum scoped change to move VS 2015 development forwards. _MSC_VER == 1900 represents the VC++ 2015 compiler. R=reillyg@chromium.org BUG=440500 Committed: https://crrev.com/38e2756fd149695916e2948ec88f96d3ea005d23 Cr-Commit-Position: refs/heads/master@{#324133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/libusb/src/libusb/os/threads_windows.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brucedawson
Another VS 2015 fix. Question: why is libusb in the third_party directory when it appears ...
5 years, 8 months ago (2015-04-07 21:09:38 UTC) #1
Reilly Grant (use Gerrit)
On 2015/04/07 21:09:38, brucedawson wrote: > Another VS 2015 fix. lgtm > Question: why is ...
5 years, 8 months ago (2015-04-07 21:14:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067093002/1
5 years, 8 months ago (2015-04-07 21:21:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 22:09:58 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:10:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38e2756fd149695916e2948ec88f96d3ea005d23
Cr-Commit-Position: refs/heads/master@{#324133}

Powered by Google App Engine
This is Rietveld 408576698