Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1067053002: Move uninteresting MD5 check to after adding it to JSON. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
jcgregorio, borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move uninteresting MD5 check to after adding it to JSON. BUG=skia:3676 Committed: https://skia.googlesource.com/skia/+/b0531a790cc4ec2f903c79206c0c1053108664f5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M dm/DM.cpp View 2 chunks +7 lines, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
mtklein_C
First LGTM wins.
5 years, 8 months ago (2015-04-07 20:32:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067053002/1
5 years, 8 months ago (2015-04-07 20:32:34 UTC) #4
jcgregorio
lgtm
5 years, 8 months ago (2015-04-07 20:36:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067053002/1
5 years, 8 months ago (2015-04-07 20:37:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b0531a790cc4ec2f903c79206c0c1053108664f5
5 years, 8 months ago (2015-04-07 20:38:53 UTC) #9
borenet
LGTM, thanks for the fix. https://codereview.chromium.org/1067053002/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1067053002/diff/1/dm/DM.cpp#newcode490 dm/DM.cpp:490: } I didn't realize ...
5 years, 8 months ago (2015-04-08 11:47:54 UTC) #10
mtklein
5 years, 8 months ago (2015-04-08 12:02:46 UTC) #11
Message was sent while issue was closed.
> I didn't realize WriteToDisk did more than write the image to disk :(

Yeah, turns out it does all the WritingToDisk, JSON too.

Powered by Google App Engine
This is Rietveld 408576698