content/public/browser/android/content_view_core.h - Issue 1067023005: Null check ContentViewCore::GetJavaObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/content_view_core.h

Issue 1067023005: Null check ContentViewCore::GetJavaObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromecast build Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/android/content_view_core.h

diff --git a/content/public/browser/android/content_view_core.h b/content/public/browser/android/content_view_core.h

index f64f672ffa98b125ff992c947c6b3876ad2f578c..e528090c6d2af7fdb881e3ed4997bdab06e57c0d 100644

--- a/content/public/browser/android/content_view_core.h

+++ b/content/public/browser/android/content_view_core.h

@@ -45,6 +45,8 @@ class CONTENT_EXPORT ContentViewCore {

static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);

virtual WebContents* GetWebContents() const = 0;

+ // May return null reference.

virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() = 0;

virtual ui::ViewAndroid* GetViewAndroid() const = 0;

virtual ui::WindowAndroid* GetWindowAndroid() const = 0;