Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2841)

Unified Diff: android_webview/native/external_video_surface_container_impl.h

Issue 1067023005: Null check ContentViewCore::GetJavaObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromecast build Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/external_video_surface_container_impl.h
diff --git a/android_webview/native/external_video_surface_container_impl.h b/android_webview/native/external_video_surface_container_impl.h
index 29e7889e44db54f6ee5d69737b1a47db2297cb41..48ccd94d4f71e804bb48e6ef55d208e0090c611f 100644
--- a/android_webview/native/external_video_surface_container_impl.h
+++ b/android_webview/native/external_video_surface_container_impl.h
@@ -20,7 +20,8 @@ class ExternalVideoSurfaceContainerImpl
typedef base::Callback<void(int, jobject)> SurfaceCreatedCB;
typedef base::Callback<void(int)> SurfaceDestroyedCB;
- ExternalVideoSurfaceContainerImpl(content::WebContents* contents);
+ static ExternalVideoSurfaceContainerImpl* Create(
+ content::WebContents* web_contents);
// ExternalVideoSurfaceContainer implementation.
void RequestExternalVideoSurface(
@@ -39,6 +40,8 @@ class ExternalVideoSurfaceContainerImpl
void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id);
private:
+ explicit ExternalVideoSurfaceContainerImpl(
+ base::android::ScopedJavaLocalRef<jobject> java_content_view_core);
~ExternalVideoSurfaceContainerImpl() override;
base::android::ScopedJavaGlobalRef<jobject> jobject_;

Powered by Google App Engine
This is Rietveld 408576698