Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: PRESUBMIT.py

Issue 1067023003: Add shell::Tracer object and wire up to --trace-startup on Android (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | shell/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 return results 633 return results
634 634
635 635
636 def _CheckSpamLogging(input_api, output_api): 636 def _CheckSpamLogging(input_api, output_api):
637 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 637 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
638 black_list = (_EXCLUDED_PATHS + 638 black_list = (_EXCLUDED_PATHS +
639 _TEST_CODE_EXCLUDED_PATHS + 639 _TEST_CODE_EXCLUDED_PATHS +
640 input_api.DEFAULT_BLACK_LIST + 640 input_api.DEFAULT_BLACK_LIST +
641 (r"^base/logging\.h$", 641 (r"^base/logging\.h$",
642 r"^base/logging\.cc$", 642 r"^base/logging\.cc$",
643 r"^shell/native_application_loader\.cc$", 643 r"^shell/application_manager/network_fetcher\.cc$",
644 r"^shell/tracer\.cc$",
644 r"^sandbox/linux/.*", 645 r"^sandbox/linux/.*",
645 r"^tools/",)) 646 r"^tools/.*"))
646 source_file_filter = lambda x: input_api.FilterSourceFile( 647 source_file_filter = lambda x: input_api.FilterSourceFile(
647 x, white_list=(file_inclusion_pattern,), black_list=black_list) 648 x, white_list=(file_inclusion_pattern,), black_list=black_list)
648 649
649 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)") 650 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)")
650 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,") 651 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,")
651 printf_macro = input_api.re.compile(r"\bprintf\(") 652 printf_macro = input_api.re.compile(r"\bprintf\(")
652 fprintf_macro = input_api.re.compile(r"\bfprintf\((stdout|stderr)") 653 fprintf_macro = input_api.re.compile(r"\bfprintf\((stdout|stderr)")
653 654
654 log_info = [] 655 log_info = []
655 printf = [] 656 printf = []
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 'Mojo ChromeOS Builder (dbg) Try', 1140 'Mojo ChromeOS Builder (dbg) Try',
1140 'Mojo ChromeOS Builder Try', 1141 'Mojo ChromeOS Builder Try',
1141 'Mojo Linux (dbg) Try', 1142 'Mojo Linux (dbg) Try',
1142 'Mojo Linux ASan Try', 1143 'Mojo Linux ASan Try',
1143 'Mojo Linux NaCl (dbg) Try', 1144 'Mojo Linux NaCl (dbg) Try',
1144 'Mojo Linux NaCl Try', 1145 'Mojo Linux NaCl Try',
1145 'Mojo Linux Try', 1146 'Mojo Linux Try',
1146 ] 1147 ]
1147 1148
1148 return GetDefaultTryConfigs(builders) 1149 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698