Add shell::Tracer object and wire up to --trace-startup on Android

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 866 matching lines @@
     return output_list
 
   return []
 
 
 def _CheckSpamLogging(input_api, output_api):
   file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
   black_list = (_EXCLUDED_PATHS +
                 _TEST_CODE_EXCLUDED_PATHS +
                 input_api.DEFAULT_BLACK_LIST +
-                (r"^base[\\\/]logging\.h$",
-                 r"^base[\\\/]logging\.cc$",
-                 r"^shell[\\\/]native_application_loader\.cc$",
-                 r"^sandbox[\\\/]linux[\\\/].*",
-                 r"^tools[\\\/]",
-                 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",))
+                (r"^base/logging\.h$",
+                 r"^base/logging\.cc$",
+                 r"^shell/application_manager/network_fetcher\.cc$",
+                 r"^shell/tracer\.cc$",
+                 r"^sandbox/linux/.*",
+                 r"^tools/"))
   source_file_filter = lambda x: input_api.FilterSourceFile(
       x, white_list=(file_inclusion_pattern,), black_list=black_list)
 
   log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)")
   log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,")
   printf_macro = input_api.re.compile(r"\bprintf\(")
   fprintf_macro = input_api.re.compile(r"\bfprintf\((stdout|stderr)")
 
   log_info = []
   printf = []
@@ skipping 115 matching lines @@
           action = 'name="{0}"'.format(action_name)
           if action not in current_actions:
             return [output_api.PresubmitPromptWarning(
               'File %s line %d: %s is missing in '
               'tools/metrics/actions/actions.xml. Please run '
               'tools/metrics/actions/extract_actions.py to update.'
               % (f.LocalPath(), line_num, action_name))]
   return []
 
 
 def _GetJSONParseError(input_api, filename, eat_comments=True):

[viettrungluu, 2015/04/07 22:05:44]

Remove the eat_comments arg?

   try:
     contents = input_api.ReadFile(filename)
-    if eat_comments:
-      json_comment_eater = input_api.os_path.join(
-          input_api.PresubmitLocalPath(),
-          'tools', 'json_comment_eater', 'json_comment_eater.py')
-      process = input_api.subprocess.Popen(
-          [input_api.python_executable, json_comment_eater],
-          stdin=input_api.subprocess.PIPE,
-          stdout=input_api.subprocess.PIPE,
-          universal_newlines=True)
-      (contents, _) = process.communicate(input=contents)
-
     input_api.json.loads(contents)
   except ValueError as e:
     return e
   return None
 
 
 def _CheckParseErrors(input_api, output_api):
   """Check that JSON files do not contain syntax errors."""
   actions = {
     '.json': _GetJSONParseError,
@@ skipping 433 matching lines @@
       'Mojo ChromeOS Builder (dbg) Try',
       'Mojo ChromeOS Builder Try',
       'Mojo Linux (dbg) Try',
       'Mojo Linux ASan Try',
       'Mojo Linux NaCl (dbg) Try',
       'Mojo Linux NaCl Try',
       'Mojo Linux Try',
   ]
 
   return GetDefaultTryConfigs(builders)