Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1066973002: Revert of Fire an alert event to notify accessibility when a permissions bubble gets shown. (Closed)

Created:
5 years, 8 months ago by David Tseng
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fire an alert event to notify accessibility when a permissions bubble gets shown. (patchset #6 id:100001 of https://codereview.chromium.org/1055883002/) Reason for revert: Not lg'ed by OWNER as of latest patchset. Original issue's description: > Add an event to notify accessibility when a permissions bubble gets shown. > > BUG=381338 > TEST=ctrl+alt+z; navigate to html5demos.com/geo; observe speech is as expected (reads contents of bubble). > > Committed: https://crrev.com/36318aa45e02cf0b5cf871bf38bbe47f3431cc8d > Cr-Commit-Position: refs/heads/master@{#323982} TBR=felt@chromium.org,markusheintz@chromium.org,dmazzoni@chromium.org,msw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=381338 Committed: https://crrev.com/449dc46f27b0deb7ed813d718c2aa88f23838f70 Cr-Commit-Position: refs/heads/master@{#324060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Tseng
Created Revert of Fire an alert event to notify accessibility when a permissions bubble gets ...
5 years, 8 months ago (2015-04-07 16:59:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066973002/1
5 years, 8 months ago (2015-04-07 17:00:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 17:01:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/449dc46f27b0deb7ed813d718c2aa88f23838f70 Cr-Commit-Position: refs/heads/master@{#324060}
5 years, 8 months ago (2015-04-07 17:03:21 UTC) #4
msw
5 years, 8 months ago (2015-04-07 19:53:28 UTC) #5
Message was sent while issue was closed.
lgtm, re-landing with some explanatory comments is probably sufficient as a
first-pass. Thanks for filing http://crbug.com/474622

Powered by Google App Engine
This is Rietveld 408576698