Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1066963002: Improve generated Makefile rules for rules with 2 outputs. (Closed)

Created:
5 years, 8 months ago by vogelheim
Modified:
5 years, 8 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/remotes/origin/master
Project:
gyp
Visibility:
Public.

Description

Improve generated Makefile rules for rules several outputs. This layers a hack upon a hack, but it should strictly improve things and the code isn't too ugly. What it does: - If a rule has (exactly) 2 outputs, this will now generate out1 out2: file.intermediate .INTERMEDIATE: file.intermediate file.intermediate: deps command - Previously, it would generate: out1: deps command out2: out1 out2: ; Why: The old rule fails if someone removes out2 from the build tree and you try to rebuild. People actually do that. R=jochen@chromium.org BUG= Committed: https://chromium.googlesource.com/external/gyp/+/2a5511bd901f328db10d0b6415c864a5ff59fc81

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : New approach. Also with tests now. #

Patch Set 4 : Fix comment. #

Patch Set 5 : Fix conflicting target names for certain rules. Also eliminate the FORCE_DO_COMMAND, which doesn't … #

Patch Set 6 : [Trying to convince the bots to accept the patch #

Total comments: 2

Patch Set 7 : Fix year in header comments #

Patch Set 8 : no changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -42 lines) Patch
M pylib/gyp/generator/make.py View 1 2 3 4 5 chunks +32 lines, -35 lines 0 comments Download
A test/actions-multiple-outputs/gyptest-multiple-outputs.py View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download
A + test/actions-multiple-outputs/src/multiple-outputs.gyp View 1 2 3 4 5 6 7 1 chunk +6 lines, -8 lines 0 comments Download
A + test/actions-multiple-outputs/src/touch.py View 1 2 6 7 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
vogelheim
5 years, 8 months ago (2015-04-07 16:56:37 UTC) #1
jochen (gone - plz use gerrit)
can you add a test for this please?
5 years, 8 months ago (2015-04-07 17:00:41 UTC) #2
vogelheim
The existing tests relied on the number of executions for a rule and thus couldn't ...
5 years, 8 months ago (2015-04-08 15:02:43 UTC) #3
vogelheim
On 2015/04/08 15:02:43, vogelheim wrote: > The existing tests relied on the number of executions ...
5 years, 8 months ago (2015-04-08 15:08:39 UTC) #4
vogelheim
On 2015/04/08 15:08:39, vogelheim wrote: > On 2015/04/08 15:02:43, vogelheim wrote: > > The existing ...
5 years, 8 months ago (2015-04-08 16:58:09 UTC) #9
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1066963002/diff/180001/test/actions-multiple-outputs/gyptest-multiple-outputs.py File test/actions-multiple-outputs/gyptest-multiple-outputs.py (right): https://codereview.chromium.org/1066963002/diff/180001/test/actions-multiple-outputs/gyptest-multiple-outputs.py#newcode3 test/actions-multiple-outputs/gyptest-multiple-outputs.py:3: # Copyright (c) 2009 Google Inc. All rights ...
5 years, 8 months ago (2015-04-09 14:46:43 UTC) #10
vogelheim
https://codereview.chromium.org/1066963002/diff/180001/test/actions-multiple-outputs/gyptest-multiple-outputs.py File test/actions-multiple-outputs/gyptest-multiple-outputs.py (right): https://codereview.chromium.org/1066963002/diff/180001/test/actions-multiple-outputs/gyptest-multiple-outputs.py#newcode3 test/actions-multiple-outputs/gyptest-multiple-outputs.py:3: # Copyright (c) 2009 Google Inc. All rights reserved. ...
5 years, 8 months ago (2015-04-09 17:12:36 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-10 16:24:39 UTC) #15
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-10 16:29:42 UTC) #19
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-14 12:21:25 UTC) #22
Message was sent while issue was closed.
Committed patchset #8 (id:260001) manually as
2a5511bd901f328db10d0b6415c864a5ff59fc81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698