Chromium Code Reviews
DescriptionImprove generated Makefile rules for rules several outputs.
This layers a hack upon a hack, but it should strictly improve things and the code isn't too ugly.
What it does:
- If a rule has (exactly) 2 outputs, this will now generate
out1 out2: file.intermediate
.INTERMEDIATE: file.intermediate
file.intermediate: deps
command
- Previously, it would generate:
out1: deps
command
out2: out1
out2: ;
Why:
The old rule fails if someone removes out2 from the build tree and you
try to rebuild. People actually do that.
R=jochen@chromium.org
BUG=
Committed: https://chromium.googlesource.com/external/gyp/+/2a5511bd901f328db10d0b6415c864a5ff59fc81
Patch Set 1 #Patch Set 2 : Fix typo. #Patch Set 3 : New approach. Also with tests now. #Patch Set 4 : Fix comment. #Patch Set 5 : Fix conflicting target names for certain rules. Also eliminate the FORCE_DO_COMMAND, which doesn't … #Patch Set 6 : [Trying to convince the bots to accept the patch #
Total comments: 2
Patch Set 7 : Fix year in header comments #Patch Set 8 : no changes #
Messages
Total messages: 22 (12 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||