Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1066933006: Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to specify extra browser args and a prefix for SKP names to webpages_playback.py BUG=skia:3763 NOTRY=true Committed: https://skia.googlesource.com/skia/+/aa31ee78eecef34128aa1eaf0e1bb9398a7caec5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M tools/skp/webpages_playback.py View 7 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
5 years, 8 months ago (2015-04-23 17:03:23 UTC) #2
borenet
LGTM
5 years, 8 months ago (2015-04-23 17:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066933006/1
5 years, 8 months ago (2015-04-23 19:47:23 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 19:47:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa31ee78eecef34128aa1eaf0e1bb9398a7caec5

Powered by Google App Engine
This is Rietveld 408576698