Use ExpressionClassifier for bindings.

Use ExpressionClassifier for bindings.

Just a refactoring, real pattern parsing comes in a later CL.

R=rossberg@chromium.org,marja@chromium.org
BUG=v8:811
LOG=N

Committed: https://crrev.com/671ac25cf9baeee1111fbe326949692b066872cb
Cr-Commit-Position: refs/heads/master@{#28084}

[Dmitry Lomov (no reviews), 2015-04-23 16:29:24]

PTAL

https://codereview.chromium.org/1066933005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1066933005/diff/1/src/parser.cc#newcode2375
src/parser.cc:2375: scope_->RemoveUnresolved(pattern->AsVariableProxy());
Here, instead of adding an unresolved proxy and then removing it, I can
propagate the information that a binding pattern is expected through the
ExpressionClassifier.

[arv (Not doing code reviews), 2015-04-23 16:52:51]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-04-23 16:52:52]

LGTM

https://codereview.chromium.org/1066933005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1066933005/diff/1/src/parser.cc#newcode2375
src/parser.cc:2375: scope_->RemoveUnresolved(pattern->AsVariableProxy());
On 2015/04/23 16:29:24, Dmitry Lomov (chromium) wrote:
> Here, instead of adding an unresolved proxy and then removing it, I can
> propagate the information that a binding pattern is expected through the
> ExpressionClassifier.

I like this better. I doubt it matters for performance.

https://codereview.chromium.org/1066933005/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/1/src/preparser.h#newcode595
src/preparser.h:595: return expression_error_ == Scanner::Location::invalid();
return expression_error_.IsValid();

[Dmitry Lomov (no reviews), 2015-04-23 17:06:50]

https://codereview.chromium.org/1066933005/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/1/src/preparser.h#newcode595
src/preparser.h:595: return expression_error_ == Scanner::Location::invalid();
On 2015/04/23 16:52:52, arv wrote:
> return expression_error_.IsValid();

Done.

[arv (Not doing code reviews), 2015-04-23 20:20:31]

https://codereview.chromium.org/1066933005/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/20001/src/preparser.h#newcode...
src/preparser.h:2019: auto result = ParseAndClassifyIdentifier(&classifier, ok);
Can't you use CHECK_OK_CUSTOM here?

auto result = ParseAndClassifyIdentifier(&classifier,
                                         CHECK_OK_CUSTOM(EmptyIdentifier));

[Dmitry Lomov (no reviews), 2015-04-24 09:51:11]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-24 09:51:11]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1066933005/#ps20001
(title: "CR feedback")

[commit-bot: I haz the power, 2015-04-24 09:51:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066933005/20001

[Dmitry Lomov (no reviews), 2015-04-24 10:03:55]

https://codereview.chromium.org/1066933005/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/20001/src/preparser.h#newcode...
src/preparser.h:2019: auto result = ParseAndClassifyIdentifier(&classifier, ok);
On 2015/04/23 20:20:30, arv wrote:
> Can't you use CHECK_OK_CUSTOM here?
> 
> auto result = ParseAndClassifyIdentifier(&classifier,
>                                          CHECK_OK_CUSTOM(EmptyIdentifier));

No because I need Traits::EmptyIdentifier()

[commit-bot: I haz the power, 2015-04-24 10:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 10:24:56]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5206)

[Dmitry Lomov (no reviews), 2015-04-27 09:56:35]

Fixed an error discovered by webkit tests + restructured patch a bit. PTAL

[Dmitry Lomov (no reviews), 2015-04-27 09:56:44]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[Dmitry Lomov (no reviews), 2015-04-27 09:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1066933005/#ps40001
(title: "Fixed webkit test issues")

[commit-bot: I haz the power, 2015-04-27 09:56:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066933005/40001

[commit-bot: I haz the power, 2015-04-27 10:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 10:21:17]

Dry run: This issue passed the CQ dry run.

[arv (Not doing code reviews), 2015-04-27 13:59:24]

Still LGTM

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h#newcode621
src/preparser.h:621: 
nit: -1 newline

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h#newcode675
src/preparser.h:675: 
inconsistent newlines

[Dmitry Lomov (no reviews), 2015-04-27 14:08:20]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-27 14:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1066933005/#ps60001
(title: "Rebasre + feedback = patch for landing")

[commit-bot: I haz the power, 2015-04-27 14:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066933005/60001

[Dmitry Lomov (no reviews), 2015-04-27 14:09:16]

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h#newcode621
src/preparser.h:621: 
On 2015/04/27 13:59:24, arv wrote:
> nit: -1 newline

Done.

https://codereview.chromium.org/1066933005/diff/40001/src/preparser.h#newcode675
src/preparser.h:675: 
On 2015/04/27 13:59:24, arv wrote:
> inconsistent newlines

Done.

[commit-bot: I haz the power, 2015-04-27 14:35:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-27 14:36:00]

Patchset 4 (id:??) landed as
https://crrev.com/671ac25cf9baeee1111fbe326949692b066872cb
Cr-Commit-Position: refs/heads/master@{#28084}