Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: components/search_provider_logos/logo_tracker.cc

Issue 1066923002: [LogoTracker] Correct fingerprint append in async parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change append_fingerprint_func_ to append_queryparams_func_. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker.cc
diff --git a/components/search_provider_logos/logo_tracker.cc b/components/search_provider_logos/logo_tracker.cc
index 969c7e48e6bffdbcb160ceccb4c730f84c685f88..0b606872b041db56da59de80f8f5f6deccd6cb13 100644
--- a/components/search_provider_logos/logo_tracker.cc
+++ b/components/search_provider_logos/logo_tracker.cc
@@ -89,7 +89,8 @@ LogoTracker::~LogoTracker() {
void LogoTracker::SetServerAPI(
const GURL& logo_url,
const ParseLogoResponse& parse_logo_response_func,
- const AppendFingerprintToLogoURL& append_fingerprint_func) {
+ const AppendQueryparamsToLogoURL& append_queryparams_func,
+ bool wants_cta) {
if (logo_url == logo_url_)
return;
@@ -97,7 +98,8 @@ void LogoTracker::SetServerAPI(
logo_url_ = logo_url;
parse_logo_response_func_ = parse_logo_response_func;
- append_fingerprint_func_ = append_fingerprint_func;
+ append_queryparams_func_ = append_queryparams_func;
+ wants_cta_ = wants_cta;
}
void LogoTracker::GetLogo(LogoObserver* observer) {
@@ -199,13 +201,12 @@ void LogoTracker::FetchLogo() {
DCHECK(!is_idle_);
GURL url;
+ std::string fingerprint;
if (cached_logo_ && !cached_logo_->metadata.fingerprint.empty() &&
cached_logo_->metadata.expiration_time >= clock_->Now()) {
- url = append_fingerprint_func_.Run(logo_url_,
- cached_logo_->metadata.fingerprint);
- } else {
- url = logo_url_;
+ fingerprint = cached_logo_->metadata.fingerprint;
}
+ url = append_queryparams_func_.Run(logo_url_, fingerprint, wants_cta_);
fetcher_.reset(net::URLFetcher::Create(url, net::URLFetcher::GET, this));
fetcher_->SetRequestContext(request_context_getter_.get());

Powered by Google App Engine
This is Rietveld 408576698