components/search_provider_logos/google_logo_api.h - Issue 1066923002: [LogoTracker] Correct fingerprint append in async parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_provider_logos/google_logo_api.h

Issue 1066923002: [LogoTracker] Correct fingerprint append in async parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change append_fingerprint_func_ to append_queryparams_func_. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/logo_service.cc ('k') | components/search_provider_logos/google_logo_api.cc » ('j') | components/search_provider_logos/logo_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_provider_logos/google_logo_api.h

diff --git a/components/search_provider_logos/google_logo_api.h b/components/search_provider_logos/google_logo_api.h

index 569752dc6bf09e1ea0a427b7783820e5e0acc347..84e41948becbfc04a0eeb407e7a98857cb3c5499 100644

--- a/components/search_provider_logos/google_logo_api.h

+++ b/components/search_provider_logos/google_logo_api.h

@@ -16,8 +16,9 @@ namespace search_provider_logos {

// Implements AppendFingerprintToLogoURL, defined in logo_tracker.h, for Google

// doodles.

-GURL GoogleAppendFingerprintToLogoURL(const GURL& logo_url,

- const std::string& fingerprint);

+GURL GoogleAppendQueryparamsToLogoURL(const GURL& logo_url,

+ const std::string& fingerprint,

+ bool wants_cta);

// Implements ParseLogoResponse, defined in logo_tracker.h, for Google doodles.

scoped_ptr<EncodedLogo> GoogleParseLogoResponse(