Tweaks for 'Encapsulate Field' assist.

pkg/analysis_server/test/services/correction/assist_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.correction.assist;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/correction/assist.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:unittest/unittest.dart';
@@ skipping 1324 matching lines @@
 class A {
   int _test = 42;
 }
 main(A a) {
   print(a._test);
 }
 ''');
     assertNoAssistAt('_test =', AssistKind.ENCAPSULATE_FIELD);
   }
 
+  void test_encapsulateField_BAD_final() {
+    resolveTestUnit('''
+class A {
+  final int test = 42;
+}
+''');
+    assertNoAssistAt('test =', AssistKind.ENCAPSULATE_FIELD);
+  }
+
   void test_encapsulateField_BAD_multipleFields() {
     resolveTestUnit('''
 class A {
   int aaa, bbb, ccc;
 }
 main(A a) {
   print(a.bbb);
 }
 ''');
     assertNoAssistAt('bbb, ', AssistKind.ENCAPSULATE_FIELD);
   }
 
+  void test_encapsulateField_BAD_notOnName() {
+    resolveTestUnit('''
+class A {
+  int test = 1 + 2 + 3;
+}
+''');
+    assertNoAssistAt('+ 2', AssistKind.ENCAPSULATE_FIELD);
+  }
+
   void test_encapsulateField_BAD_parseError() {
     verifyNoTestUnitErrors = false;
     resolveTestUnit('''
 class A {
   int; // marker
 }
 main(A a) {
   print(a.test);
 }
 ''');
     assertNoAssistAt('; // marker', AssistKind.ENCAPSULATE_FIELD);
   }
 
+  void test_encapsulateField_BAD_static() {
+    resolveTestUnit('''
+class A {
+  static int test = 42;
+}
+''');
+    assertNoAssistAt('test =', AssistKind.ENCAPSULATE_FIELD);
+  }
+
   void test_encapsulateField_OK_hasType() {
     resolveTestUnit('''
 class A {
   int test = 42;
+  A(this.test);
 }
 main(A a) {
   print(a.test);
 }
 ''');
     assertHasAssistAt('test = 42', AssistKind.ENCAPSULATE_FIELD, '''
 class A {
   int _test = 42;
 
   int get test => _test;
 
   void set test(int test) {
     _test = test;
   }
+  A(this._test);
 }
 main(A a) {
   print(a.test);
 }
 ''');
   }
 
   void test_encapsulateField_OK_noType() {
     resolveTestUnit('''
 class A {
@@ skipping 1638 matching lines @@
       positions.add(new Position(testFile, offset));
     }
     return positions;
   }
 
   void _setStartEndSelection() {
     offset = findOffset('// start\n') + '// start\n'.length;
     length = findOffset('// end') - offset;
   }
 }