Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1066903002:
Roll trace-viewer deps to the latest. (Closed)
|
Created:
5 years, 8 months ago by nednguyen Modified:
5 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll trace-viewer deps to the latest.
Modify tracing_ui.cc to add record-as-much-as-possible mode for about://tracing.
This time, the roll should decrease trace-viewer size from 1.6 M -> 1.4 M with
minification using rjsmin.
Verified that the size of resources.pak reduces from 17278967 to 16888789.
BUG=396081, 471610, 469646
Committed: https://crrev.com/52fa705a8d4ea770f07d229ebde9b7df8544e532
Cr-Commit-Position: refs/heads/master@{#324192}
Patch Set 1 : #Patch Set 2 : Update trace-viewer DEPS to latest #Patch Set 3 : Update value/trace.py to deal with UTF-8 #Patch Set 4 : Update trace-viewer DEPS to fix license problem #
Messages
Total messages: 36 (19 generated)
Patchset #1 (id:1) has been deleted
nednguyen@google.com changed reviewers: + nduca@chromium.org
BUAHAHAHA Lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org Link to the patchset: https://codereview.chromium.org/1066903002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org Link to the patchset: https://codereview.chromium.org/1066903002/#ps80001 (title: "Update value/trace.py to deal with UTF-8")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/80001
nednguyen@google.com changed reviewers: + thestig@chromium.org
+Lei since I needs to whitelist third_party/trace-viewer/third_party/tvcm/third_party/ The LICENSE file for third_party/trace-viewer/third_party/tvcm/third_party/rjsmin/ is: https://github.com/google/trace-viewer/blob/master/third_party/tvcm/third_par... The LICENSE file for third_party/trace-viewer/third_party/tvcm/third_party/rcssmin/ is: https://github.com/google/trace-viewer/blob/master/third_party/tvcm/third_par...
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org Link to the patchset: https://codereview.chromium.org/1066903002/#ps100001 (title: "Update checklicenses to whitelist third_party/trace-viewer/third_party/tvcm/third_party/")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Actually, if we can land https://codereview.appspot.com/224260043/, it would fix the license problem
On 2015/04/08 02:25:14, nednguyen wrote: > Actually, if we can land https://codereview.appspot.com/224260043/, it would fix > the license problem That would be preferable. Then you won't need me to review.
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org Link to the patchset: https://codereview.chromium.org/1066903002/#ps120001 (title: "Update trace-viewer DEPS to fix license problem")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066903002/120001
Message was sent while issue was closed.
Committed patchset #4 (id:120001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/52fa705a8d4ea770f07d229ebde9b7df8544e532 Cr-Commit-Position: refs/heads/master@{#324192} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
