Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1066873002: Simplify instanceof optimization; don't duplicate lookup (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify instanceof optimization; don't duplicate lookup BUG= Committed: https://crrev.com/2585bf79bdd3288bcd1303e67fb42e2e3c003810 Cr-Commit-Position: refs/heads/master@{#27635}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Support newspace values as they are loaded through a cell #

Patch Set 4 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -31 lines) Patch
M src/hydrogen.cc View 1 2 3 1 chunk +9 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 8 months ago (2015-04-07 15:17:43 UTC) #2
Igor Sheludko
lgtm
5 years, 8 months ago (2015-04-07 15:36:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066873002/60001
5 years, 8 months ago (2015-04-07 15:38:03 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-07 16:11:26 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 16:11:40 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2585bf79bdd3288bcd1303e67fb42e2e3c003810
Cr-Commit-Position: refs/heads/master@{#27635}

Powered by Google App Engine
This is Rietveld 408576698