Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1066843002: Run OAuth token handle check upon user pod selction. (Closed)

Created:
5 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run OAuth token handle check upon user pod selction. Use one umbrella command line switch. BUG=469984, 462445 R=nkostylev@chromium.org Committed: https://crrev.com/eed5d29a500020e3547de253041d400945dc516c Cr-Commit-Position: refs/heads/master@{#324036}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -49 lines) Patch
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 2 chunks +30 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Denis Kuznetsov (DE-MUC)
5 years, 8 months ago (2015-04-07 10:22:05 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/1066843002/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): https://codereview.chromium.org/1066843002/diff/1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode1240 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1240: delegate_->CheckUserStatus(user_id); FocusPod maybe called multiple times per user ...
5 years, 8 months ago (2015-04-07 11:18:10 UTC) #2
Nikita (slow)
On 2015/04/07 11:18:10, Nikita Kostylev wrote: > As discussed offline, I'll file a separate bug ...
5 years, 8 months ago (2015-04-07 11:53:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066843002/1
5 years, 8 months ago (2015-04-07 13:14:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 13:47:50 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 13:48:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eed5d29a500020e3547de253041d400945dc516c
Cr-Commit-Position: refs/heads/master@{#324036}

Powered by Google App Engine
This is Rietveld 408576698