Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/liblouis/liblouis_nacl.gyp

Issue 1066823003: [NaCl SDK] Remove create_nmf dependency on NACL_SDK_ROOT env var (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/ppapi_nacl_test_common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/liblouis/liblouis_nacl.gyp
diff --git a/third_party/liblouis/liblouis_nacl.gyp b/third_party/liblouis/liblouis_nacl.gyp
index 82336b86ef0cd8be5fdca74e9f91815b1da5097d..081658fba3c2f31583d35b6af487d5d985a21d35 100644
--- a/third_party/liblouis/liblouis_nacl.gyp
+++ b/third_party/liblouis/liblouis_nacl.gyp
@@ -138,6 +138,8 @@
'<(DEPTH)/native_client_sdk/src/tools/create_nmf.py',
'>@(_inputs)',
'--output=>(nmf)',
+ '--no-default-libpath',
binji 2015/04/07 19:44:02 it seems that this change is the only difference b
Sam Clegg 2015/04/07 20:11:53 No, I guess the bots don't test this otherwise the
+ '--objdump=>(nacl_glibc_tc_root)/bin/x86_64-nacl-objdump',
binji 2015/04/07 21:17:39 does this need to be nacl_newlib_tc_root? Shouldn'
Sam Clegg 2015/04/09 00:26:01 It won't actually use the objdump executable unles
],
},
],
« no previous file with comments | « ppapi/ppapi_nacl_test_common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698