Websocket should fire 'error' event if no server available

net/socket_stream/socket_stream.cc

Index: net/socket_stream/socket_stream.cc
diff --git a/net/socket_stream/socket_stream.cc b/net/socket_stream/socket_stream.cc
index 84b58bc2380d676223c6d35e2aae96ef58e7eb35..70f14629295fe94e508529cc056b4104c80b3375 100644
--- a/net/socket_stream/socket_stream.cc
+++ b/net/socket_stream/socket_stream.cc
@@ -359,7 +359,8 @@ void SocketStream::Finish(int result) {
   Delegate* delegate = delegate_;
   delegate_ = NULL;
   if (delegate) {
-    delegate->OnError(this, result);
+    if (result != ERR_CONNECTION_CLOSED && result != ERR_PROTOCOL_SWITCHED)

[Li Yin, 2013/04/26 06:57:18]

I am unfamiliar with SwitchToSpdy related code, and don't know if this fix is
reasonable. Could you please have a look how to change TEST_F(SocketStreamTest,
SwitchToSpdy) and TEST_F(SocketStreamTest, SwitchAfterPending)?
Thanks.

[tyoshino (SeeGerritForStatus), 2013/04/26 07:19:43]

Yes. I'm looking here too. Raising ERR_PROTOCOL_SWITCHED is fine for
WebSocketJob. Sorry. You can remove result != ERR_PROTOCOL_SWITCHED from here.

But even with that, we still need to fix some part in the unittest.

As we've changed Blink side not to deref on OnError, it makes sense to change
the recorder to call completion callback on OnClose call instead. Then, we need
to change L364 too. I.e. removing if-clause.

But then some of Spdy tests fail. I'm looking

+      delegate->OnError(this, result);
     if (result != ERR_PROTOCOL_SWITCHED)
       delegate->OnClose(this);
   }