Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106673003: Update the selected resolution to the resolution that is actually selected. (Closed)

Created:
7 years ago by oshima
Modified:
6 years, 11 months ago
Reviewers:
Jun Mukai, dsodman
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Update the selected resolution to the resolution that is actually selected. BUG=309720 TEST=covered by test. Also tested manually R=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243627

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fix display_info #

Patch Set 4 : rebase #

Patch Set 5 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -5 lines) Patch
M ash/display/display_info.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.cc View 2 4 1 chunk +15 lines, -0 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 2 3 4 2 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
oshima
7 years ago (2013-12-14 02:46:06 UTC) #1
oshima
7 years ago (2013-12-14 02:46:12 UTC) #2
Jun Mukai
lgtm
7 years ago (2013-12-14 08:10:26 UTC) #3
dsodman
One comment below. Otherwise looks good and I verified the change https://codereview.chromium.org/106673003/diff/20001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): ...
7 years ago (2013-12-16 18:15:17 UTC) #4
oshima
https://codereview.chromium.org/106673003/diff/20001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/106673003/diff/20001/ash/display/display_manager.cc#newcode555 ash/display/display_manager.cc:555: const gfx::Size& resolution = iter->bounds_in_native().size(); On 2013/12/16 18:15:17, dsodman ...
7 years ago (2013-12-16 18:50:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/106673003/40001
7 years ago (2013-12-16 19:00:48 UTC) #6
oshima
On 2013/12/16 18:50:55, oshima wrote: > https://codereview.chromium.org/106673003/diff/20001/ash/display/display_manager.cc > File ash/display/display_manager.cc (right): > > https://codereview.chromium.org/106673003/diff/20001/ash/display/display_manager.cc#newcode555 > ...
7 years ago (2013-12-16 19:42:18 UTC) #7
Jun Mukai
lgtm++
7 years ago (2013-12-19 20:50:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/106673003/60001
7 years ago (2013-12-19 20:52:54 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=186720
7 years ago (2013-12-19 22:20:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/106673003/160001
6 years, 11 months ago (2014-01-08 06:29:59 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243189
6 years, 11 months ago (2014-01-08 08:45:00 UTC) #12
oshima
6 years, 11 months ago (2014-01-08 19:25:51 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 manually as r243627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698