Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1066683009: [Android WebView] Add a test for passing several arguments to console.log (Closed)

Created:
5 years, 8 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Add a test for passing several arguments to console.log Just add a disabled test for now that reveals the problem. BUG=481013 Committed: https://crrev.com/d38e92db6cff249283142ec224395818fb6b7ff2 Cr-Commit-Position: refs/heads/master@{#327987}

Patch Set 1 #

Patch Set 2 : Remove Log.w line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/ClientAddMessageToConsoleTest.java View 1 8 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mnaganov (inactive)
5 years, 8 months ago (2015-04-24 15:24:02 UTC) #2
Torne
lgtm
5 years, 7 months ago (2015-04-30 13:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066683009/1
5 years, 7 months ago (2015-05-01 15:52:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60527)
5 years, 7 months ago (2015-05-01 15:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066683009/20001
5 years, 7 months ago (2015-05-01 21:18:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 21:40:48 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 21:41:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d38e92db6cff249283142ec224395818fb6b7ff2
Cr-Commit-Position: refs/heads/master@{#327987}

Powered by Google App Engine
This is Rietveld 408576698