Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1066663005: Revert "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Michael Starzinger, mvstanton, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations" This reverts commit 8c98cc074ef8278ce1c4dcd4790e8aaf6fbeedc6 because it causes flaky failures in the dromaeo.jslibeventprototype benchmark on Linux/Windows and consistent failures on Android. Also reverts the followup "Remove kForInStatementIsNotFastCase bailout reason" (commit ba24e6769615d0ea7f7b5a31c5947769892f93a7) to avoid breaking the build. BUG=chromium:476592 TBR=verwaest@chromium.org LOG=y Committed: https://crrev.com/b054ff46203cc86a2e180f2bb5b45a7106810e9b Cr-Commit-Position: refs/heads/master@{#27859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -128 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +23 lines, -53 lines 0 comments Download
D test/mjsunit/for-in-opt.js View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
5 years, 8 months ago (2015-04-15 21:00:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066663005/1
5 years, 8 months ago (2015-04-15 21:00:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2031)
5 years, 8 months ago (2015-04-15 21:04:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066663005/1
5 years, 8 months ago (2015-04-15 21:05:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 21:28:35 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:28:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b054ff46203cc86a2e180f2bb5b45a7106810e9b
Cr-Commit-Position: refs/heads/master@{#27859}

Powered by Google App Engine
This is Rietveld 408576698