Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1066663002: Guarantee CleanUpAfterPage gets run even if CloseConnection fails. (Closed)

Created:
5 years, 8 months ago by aiolos (Not reviewing)
Modified:
5 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guarantee CleanUpAfterPage gets run even if CloseConnection fails. BUG=474269 Committed: https://crrev.com/2d52933efb1a72ed868178997c64c9add4830277 Cr-Commit-Position: refs/heads/master@{#323970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M tools/telemetry/telemetry/page/shared_page_state.py View 1 chunk +14 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aiolos (Not reviewing)
5 years, 8 months ago (2015-04-06 22:04:58 UTC) #2
nednguyen
lgtm
5 years, 8 months ago (2015-04-06 22:08:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066663002/1
5 years, 8 months ago (2015-04-06 22:14:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 23:00:09 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 23:01:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d52933efb1a72ed868178997c64c9add4830277
Cr-Commit-Position: refs/heads/master@{#323970}

Powered by Google App Engine
This is Rietveld 408576698