Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1066653003: Insert a filler at the new space top even if the top is at the limit. (Closed)

Created:
5 years, 8 months ago by Jarin
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Insert a filler at the new space top even if the top is at the limit. BUG=chromium:470390 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/31994391ab2c39e709e7a4b7ff96d7f2ddc1fcd3 Cr-Commit-Position: refs/heads/master@{#27819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/heap/heap.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 8 months ago (2015-04-14 12:59:59 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-14 13:19:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066653003/1
5 years, 8 months ago (2015-04-14 13:41:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 13:42:35 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 13:42:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31994391ab2c39e709e7a4b7ff96d7f2ddc1fcd3
Cr-Commit-Position: refs/heads/master@{#27819}

Powered by Google App Engine
This is Rietveld 408576698