Issue 106663006: Followup for bug when zipping a folder with non-ascii chars in its name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106663006: Followup for bug when zipping a folder with non-ascii chars in its name. (Closed)

Created:
7 years ago by João Eiras

Modified:
7 years ago

Reviewers:
satorux1, hshi1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Followup for bug when zipping a folder with non-ascii chars in its name. The commit adds a unit test and replaces the substr with the more stylistically adequate FilePath::AppendRelativePath. BUG=248115 TEST=ZipTest.ZipNonASCIIDir Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239474

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	third_party/zlib/google/zip.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	third_party/zlib/google/zip_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

João Eiras

We (Opera) also hit bug 248115, so we had this patch for a while, while ...

7 years ago (2013-12-06 14:27:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/106663006/1

7 years ago (2013-12-09 09:52:49 UTC) #3

Message was sent while issue was closed.

Change committed as 239474

Expand Messages | Collapse Messages