Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated sync value conversions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/protocol/proto_value_conversions.h ('k') | sync/protocol/proto_value_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index de55704dfcb568e2c250fe2ce9fcaaafa3b7cfe7..f169f4f33348081a98243b4e33271abc554244cb 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -298,6 +298,14 @@ base::DictionaryValue* AppSettingSpecificsToValue(
return value;
}
+base::DictionaryValue* LinkedAppIconInfoToValue(
+ const sync_pb::LinkedAppIconInfo& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_STR(url);
+ SET_INT32(size);
+ return value;
+}
+
base::DictionaryValue* AppSpecificsToValue(
const sync_pb::AppSpecifics& proto) {
base::DictionaryValue* value = new base::DictionaryValue();
@@ -308,6 +316,8 @@ base::DictionaryValue* AppSpecificsToValue(
SET_ENUM(launch_type, GetLaunchTypeString);
SET_STR(bookmark_app_url);
SET_STR(bookmark_app_description);
+ SET_STR(bookmark_app_icon_color);
+ SET_REP(linked_app_icons, LinkedAppIconInfoToValue);
return value;
}
« no previous file with comments | « sync/protocol/proto_value_conversions.h ('k') | sync/protocol/proto_value_conversions_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698