Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: sync/protocol/app_specifics.proto

Issue 1066623008: Sync bookmark app icon urls and sizes, and download icons for new apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated sync value conversions Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/manifest_constants.cc ('k') | sync/protocol/proto_value_conversions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for apps. 5 // Sync protocol datatype extension for apps.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 20 matching lines...) Expand all
31 // OAuth2 client id to which the user granted the notification permission. 31 // OAuth2 client id to which the user granted the notification permission.
32 // This field will start out empty. 32 // This field will start out empty.
33 // It will be set when the user accepts receiving notifications. 33 // It will be set when the user accepts receiving notifications.
34 // This field is used when the user revokes the notifications permission. 34 // This field is used when the user revokes the notifications permission.
35 // Note that it is never cleared after it was set once. Hence, the presence 35 // Note that it is never cleared after it was set once. Hence, the presence
36 // of this field can be used to determine if the user has setup notifications 36 // of this field can be used to determine if the user has setup notifications
37 // at least once for the given app. 37 // at least once for the given app.
38 optional string oauth_client_id = 3; 38 optional string oauth_client_id = 3;
39 } 39 }
40 40
41 // Information about a linked app icon.
42 message LinkedAppIconInfo {
43 // The URL of the app icon.
44 optional string url = 1;
45
46 // The size of the app icon in DIPs.
47 optional uint32 size = 2;
48 }
49
41 // Properties of app sync objects. 50 // Properties of app sync objects.
42 // 51 //
43 // For now, an app is just an extension. We keep the two data types 52 // For now, an app is just an extension. We keep the two data types
44 // separate for future-proofing purposes. 53 // separate for future-proofing purposes.
45 message AppSpecifics { 54 message AppSpecifics {
46 // Extension data. 55 // Extension data.
47 optional ExtensionSpecifics extension = 1; 56 optional ExtensionSpecifics extension = 1;
48 57
49 // Notification settings. 58 // Notification settings.
50 optional AppNotificationSettings notification_settings = 2; 59 optional AppNotificationSettings notification_settings = 2;
(...skipping 21 matching lines...) Expand all
72 // This is the url of a bookmark app. If this exists, the app is a bookmark 81 // This is the url of a bookmark app. If this exists, the app is a bookmark
73 // app. 82 // app.
74 optional string bookmark_app_url = 6; 83 optional string bookmark_app_url = 6;
75 84
76 // This is the description of a bookmark app. 85 // This is the description of a bookmark app.
77 optional string bookmark_app_description = 7; 86 optional string bookmark_app_description = 7;
78 87
79 // This is the color to use when generating bookmark app icons. The string is 88 // This is the color to use when generating bookmark app icons. The string is
80 // in #rrggbb or #rgb syntax, e.g. #d8d8d8. 89 // in #rrggbb or #rgb syntax, e.g. #d8d8d8.
81 optional string bookmark_app_icon_color = 8; 90 optional string bookmark_app_icon_color = 8;
91
92 // This is information about linked icons (that is, icons that are downloaded
93 // from outside the app's bundle of files.
94 repeated LinkedAppIconInfo linked_app_icons = 9;
82 } 95 }
OLDNEW
« no previous file with comments | « extensions/common/manifest_constants.cc ('k') | sync/protocol/proto_value_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698