Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1066613002: Revert of Don't process HSTS/HPKP headers when host is an IP address (Closed)

Created:
5 years, 8 months ago by estark
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't process HSTS/HPKP headers when host is an IP address (patchset #9 id:160001 of https://codereview.chromium.org/1059303002/) Reason for revert: This change seems to break WebSockets tests broken on Mac: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/758 Tests need to be fixed before it can be re-landed. Original issue's description: > Don't process HSTS/HPKP headers when host is an IP address > > HSTS/HPKP headers should only be parsed when the host is not an IP > address. This change requires fixing the HSTS/HPKP tests to use > localhost test server URLs instead of 127.0.0.1, with a corresponding > cert. > > BUG=456712 > > Committed: https://crrev.com/8488b5886ccec4820578905acd42f95cf42f5b17 > Cr-Commit-Position: refs/heads/master@{#323913} TBR=rsleevi@chromium.org,palmer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456712 Committed: https://crrev.com/92df3fd083f59271884ad136cad9996f462b8c1b Cr-Commit-Position: refs/heads/master@{#323939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -286 lines) Patch
M chrome/browser/net/websocket_browsertest.cc View 2 chunks +9 lines, -14 lines 0 comments Download
D net/data/ssl/certificates/localhost_cert.pem View 1 chunk +0 lines, -111 lines 0 comments Download
M net/data/ssl/scripts/ee.cnf View 1 chunk +0 lines, -10 lines 0 comments Download
M net/data/ssl/scripts/generate-aia-certs.sh View 1 chunk +2 lines, -1 line 0 comments Download
M net/data/ssl/scripts/generate-cross-signed-certs.sh View 2 chunks +9 lines, -4 lines 0 comments Download
M net/data/ssl/scripts/generate-policy-certs.sh View 1 chunk +2 lines, -1 line 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 5 chunks +5 lines, -22 lines 0 comments Download
M net/data/url_request_unittest/hpkp-headers.html.mock-http-headers View 1 chunk +1 line, -1 line 0 comments Download
M net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers View 1 chunk +1 line, -1 line 0 comments Download
M net/data/url_request_unittest/hsts-and-hpkp-headers2.html.mock-http-headers View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 13 chunks +17 lines, -88 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
estark
Created Revert of Don't process HSTS/HPKP headers when host is an IP address
5 years, 8 months ago (2015-04-06 19:54:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066613002/1
5 years, 8 months ago (2015-04-06 19:55:42 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-06 19:55:44 UTC) #4
Sergey Ulanov
lgtm
5 years, 8 months ago (2015-04-06 19:56:08 UTC) #6
Sergey Ulanov
lgtm
5 years, 8 months ago (2015-04-06 19:56:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066613002/1
5 years, 8 months ago (2015-04-06 19:56:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 19:57:59 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 20:05:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92df3fd083f59271884ad136cad9996f462b8c1b
Cr-Commit-Position: refs/heads/master@{#323939}

Powered by Google App Engine
This is Rietveld 408576698