Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1066603002: Change get_uploaded_hashes.py to query Gold for hashes instead of GS (Closed)

Created:
5 years, 8 months ago by borenet
Modified:
5 years, 8 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change get_uploaded_hashes.py to query Gold for hashes instead of GS This is a lot faster: ~4 seconds instead of > 1 minute BUG=skia:3521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M tools/get_uploaded_hashes.py View 1 chunk +8 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
borenet
5 years, 8 months ago (2015-04-06 19:02:02 UTC) #2
mtklein
lgtm
5 years, 8 months ago (2015-04-06 19:05:33 UTC) #3
jcgregorio
lgtm
5 years, 8 months ago (2015-04-06 19:05:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066603002/1
5 years, 8 months ago (2015-04-06 19:08:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/173) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 8 months ago (2015-04-06 19:11:43 UTC) #8
borenet
5 years, 8 months ago (2015-04-06 19:33:25 UTC) #9 
On 2015/04/06 19:11:43, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
>
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
>   Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
> (JOB_FAILED,
>
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

Replaced this CL with https://codereview.chromium.org/1068503002/

Powered by Google App Engine
This is Rietveld 408576698