Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1066573005: Restore V8_LIBC_UCLIBC as a libc option. (Closed)

Created:
5 years, 8 months ago by smcgruer2
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restore V8_LIBC_UCLIBC as a libc option. As uClibc defines __GLIBC__ in an attempt to look like glibc, V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc before glibc fixes this and restores the correct behavior. BUG= Committed: https://crrev.com/a684535693b4949e4863d0f60178ac3fc6638e82 Cr-Commit-Position: refs/heads/master@{#27806}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M include/v8config.h View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
smcgruer2
https://codereview.chromium.org/1066573005/diff/1/include/v8config.h File include/v8config.h (right): https://codereview.chromium.org/1066573005/diff/1/include/v8config.h#newcode127 include/v8config.h:127: // V8_LIBC_UCLIBC - uClibc I'm on the fence about ...
5 years, 8 months ago (2015-04-13 16:41:25 UTC) #2
Benedikt Meurer
lgtm
5 years, 8 months ago (2015-04-14 07:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066573005/1
5 years, 8 months ago (2015-04-14 07:29:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 07:54:35 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 07:54:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a684535693b4949e4863d0f60178ac3fc6638e82
Cr-Commit-Position: refs/heads/master@{#27806}

Powered by Google App Engine
This is Rietveld 408576698