Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1066573003: cros: Use webview.addContentScripts for new Gaia SAML. (Closed)

Created:
5 years, 8 months ago by xiyuan
Modified:
5 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webview-content-script-incognito
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Use webview.addContentScripts for new Gaia SAML. - Use webview.addContentScripts to to inject js; - Enable crendential passing tests; - Make the test listen for authFlowChange event only when needed because it is fired on every auth page load now to correctly propagate the auth domain change; BUG=467068 Committed: https://crrev.com/af7b6fb09cfc4eb8591901b7442c4bf5f5af800d Cr-Commit-Position: refs/heads/master@{#327114}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : only inject into http/https #

Patch Set 4 : rebase, use code injection instead of file #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -65 lines) Patch
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 3 4 5 chunks +17 lines, -22 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/saml_handler.js View 1 2 3 4 4 chunks +8 lines, -25 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/webview_saml_injected.js View 1 chunk +2 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xiyuan
Sent out for early review. Note it depends on https://codereview.chromium.org/1056533002/ (API CL and incognito fix ...
5 years, 8 months ago (2015-04-06 23:17:25 UTC) #2
dzhioev (left Google)
LGTM +Dmitry for saml_browsertest.cc review.
5 years, 8 months ago (2015-04-07 14:32:14 UTC) #4
Dmitry Polukhin
LGTM SAML test but this CL will have merge conflicts with https://codereview.chromium.org/1054403002
5 years, 8 months ago (2015-04-07 14:39:23 UTC) #5
xiyuan
Almost there. The last piece this CL depends on is https://codereview.chromium.org/1062963006/ (make AddContentScript work for ...
5 years, 8 months ago (2015-04-27 17:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066573003/100001
5 years, 8 months ago (2015-04-27 19:34:34 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-27 20:19:57 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 20:20:50 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/af7b6fb09cfc4eb8591901b7442c4bf5f5af800d
Cr-Commit-Position: refs/heads/master@{#327114}

Powered by Google App Engine
This is Rietveld 408576698