Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: Source/devtools/front_end/components/HandlerRegistry.js

Issue 1066573002: DevTools: migrate from ui-setting to settings extension point. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/Runtime.js ('k') | Source/devtools/front_end/components/module.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 * @return {boolean} 291 * @return {boolean}
292 */ 292 */
293 handleLink: function(url, lineNumber) 293 handleLink: function(url, lineNumber)
294 { 294 {
295 return WebInspector.openAnchorLocationRegistry.dispatch({ url: url, line Number: lineNumber}); 295 return WebInspector.openAnchorLocationRegistry.dispatch({ url: url, line Number: lineNumber});
296 } 296 }
297 } 297 }
298 298
299 /** 299 /**
300 * @constructor 300 * @constructor
301 * @extends {WebInspector.UISettingDelegate} 301 * @implements {WebInspector.SettingUI}
302 */ 302 */
303 WebInspector.HandlerRegistry.OpenAnchorLocationSettingDelegate = function() 303 WebInspector.HandlerRegistry.OpenAnchorLocationSettingUI = function()
304 { 304 {
305 WebInspector.UISettingDelegate.call(this);
306 } 305 }
307 306
308 WebInspector.HandlerRegistry.OpenAnchorLocationSettingDelegate.prototype = { 307 WebInspector.HandlerRegistry.OpenAnchorLocationSettingUI.prototype = {
309 /** 308 /**
310 * @override 309 * @override
311 * @return {?Element} 310 * @return {?Element}
312 */ 311 */
313 settingElement: function() 312 settingElement: function()
314 { 313 {
315 if (!WebInspector.openAnchorLocationRegistry.handlerNames.length) 314 if (!WebInspector.openAnchorLocationRegistry.handlerNames.length)
316 return null; 315 return null;
317 316
318 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry); 317 var handlerSelector = new WebInspector.HandlerSelector(WebInspector.open AnchorLocationRegistry);
319 return WebInspector.SettingsUI.createCustomSetting(WebInspector.UIString ("Open links in"), handlerSelector.element); 318 return WebInspector.SettingsUI.createCustomSetting(WebInspector.UIString ("Open links in"), handlerSelector.element);
320 }, 319 }
321
322 __proto__: WebInspector.UISettingDelegate.prototype
323 } 320 }
324 321
325 /** 322 /**
326 * @type {!WebInspector.HandlerRegistry} 323 * @type {!WebInspector.HandlerRegistry}
327 */ 324 */
328 WebInspector.openAnchorLocationRegistry; 325 WebInspector.openAnchorLocationRegistry;
OLDNEW
« no previous file with comments | « Source/devtools/front_end/Runtime.js ('k') | Source/devtools/front_end/components/module.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698