Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/apps/guest_view/app_view_browsertest.cc

Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions_guest_view_message_filter
Patch Set: Fixed NavigateGuest Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/app_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/app_view_browsertest.cc b/chrome/browser/apps/guest_view/app_view_browsertest.cc
index 8ddc15d7d40942de10f6b32c8146a387422f5cc2..9a6ba6b334e770c89aeff6185709ae290d6591da 100644
--- a/chrome/browser/apps/guest_view/app_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/app_view_browsertest.cc
@@ -10,83 +10,19 @@
#include "content/public/test/test_utils.h"
#include "extensions/browser/guest_view/guest_view_manager.h"
#include "extensions/browser/guest_view/guest_view_manager_factory.h"
+#include "extensions/browser/guest_view/test_guest_view_manager.h"
#include "extensions/common/switches.h"
#include "extensions/test/extension_test_message_listener.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/embedded_test_server/http_request.h"
#include "net/test/embedded_test_server/http_response.h"
-namespace {
-
-class TestGuestViewManager : public extensions::GuestViewManager {
- public:
- explicit TestGuestViewManager(content::BrowserContext* context) :
- extensions::GuestViewManager(context),
- web_contents_(NULL) {}
-
- content::WebContents* WaitForGuestCreated() {
- if (web_contents_)
- return web_contents_;
-
- message_loop_runner_ = new content::MessageLoopRunner;
- message_loop_runner_->Run();
- return web_contents_;
- }
-
- private:
- // GuestViewManager override:
- void AddGuest(int guest_instance_id,
- content::WebContents* guest_web_contents) override {
- extensions::GuestViewManager::AddGuest(
- guest_instance_id, guest_web_contents);
- web_contents_ = guest_web_contents;
-
- if (message_loop_runner_.get())
- message_loop_runner_->Quit();
- }
-
- content::WebContents* web_contents_;
- scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
-};
-
-// Test factory for creating test instances of GuestViewManager.
-class TestGuestViewManagerFactory : public extensions::GuestViewManagerFactory {
- public:
- TestGuestViewManagerFactory() :
- test_guest_view_manager_(NULL) {}
-
- ~TestGuestViewManagerFactory() override {}
-
- extensions::GuestViewManager* CreateGuestViewManager(
- content::BrowserContext* context) override {
- return GetManager(context);
- }
-
- TestGuestViewManager* GetManager(content::BrowserContext* context) {
- if (!test_guest_view_manager_) {
- test_guest_view_manager_ = new TestGuestViewManager(context);
- }
- return test_guest_view_manager_;
- }
-
- private:
- TestGuestViewManager* test_guest_view_manager_;
-
- DISALLOW_COPY_AND_ASSIGN(TestGuestViewManagerFactory);
-};
-
-} // namespace
-
class AppViewTest : public extensions::PlatformAppBrowserTest {
public:
AppViewTest() {
extensions::GuestViewManager::set_factory_for_testing(&factory_);
}
- TestGuestViewManager* GetGuestViewManager() {
- return factory_.GetManager(browser()->profile());
- }
-
enum TestServer {
NEEDS_TEST_SERVER,
NO_TEST_SERVER
@@ -134,7 +70,7 @@ class AppViewTest : public extensions::PlatformAppBrowserTest {
extensions::PlatformAppBrowserTest::SetUpCommandLine(command_line);
}
- TestGuestViewManagerFactory factory_;
+ extensions::TestGuestViewManagerFactory factory_;
};
// Tests that <appview> is able to navigate to another installed app.
« no previous file with comments | « no previous file | chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698