extensions/browser/guest_view/surface_worker/surface_worker_guest.cc - Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/surface_worker/surface_worker_guest.cc

Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions_guest_view_message_filter

Patch Set: Fixed tests I hope Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_event.cc ('K') | « extensions/browser/guest_view/guest_view_message_filter.cc ('k') | extensions/browser/guest_view/test_guest_view_manager.h » ('j') | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/surface_worker/surface_worker_guest.cc

diff --git a/extensions/browser/guest_view/surface_worker/surface_worker_guest.cc b/extensions/browser/guest_view/surface_worker/surface_worker_guest.cc

index 2dffde38579000742e4e690f789cd08018aa87ea..6c30d9ccb21d6dcc91c9975a64fa2afac4ad319e 100644

--- a/extensions/browser/guest_view/surface_worker/surface_worker_guest.cc

+++ b/extensions/browser/guest_view/surface_worker/surface_worker_guest.cc

@@ -65,9 +65,8 @@ void SurfaceWorkerGuest::CreateWebContents(

content::kGuestScheme,

GetOwnerSiteURL().host().c_str()));

- GuestViewManager* guest_view_manager =

- GuestViewManager::FromBrowserContextIfAvailable(

- owner_web_contents()->GetBrowserContext());

+ GuestViewManager* guest_view_manager = GuestViewManager::FromBrowserContext(

+ owner_web_contents()->GetBrowserContext());

content::SiteInstance* guest_site_instance =

guest_view_manager->GetGuestSiteInstance(guest_site);

WebContents::CreateParams params(