extensions/browser/guest_view/guest_view_manager_factory.h - Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager_factory.h

Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions_guest_view_message_filter

Patch Set: Fixed tests I hope Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_event.cc ('K') | « extensions/browser/guest_view/guest_view_manager_delegate.h ('k') | extensions/browser/guest_view/guest_view_manager_unittest.cc » ('j') | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager_factory.h

diff --git a/extensions/browser/guest_view/guest_view_manager_factory.h b/extensions/browser/guest_view/guest_view_manager_factory.h

index 913373489dcc118d4d984b224f92db7a17961759..695731cb1423a20deec8129da7ace9b8393d3dd2 100644

--- a/extensions/browser/guest_view/guest_view_manager_factory.h

+++ b/extensions/browser/guest_view/guest_view_manager_factory.h

@@ -9,6 +9,10 @@ namespace content {

class BrowserContext;

}

+namespace guestview {

+class GuestViewManagerDelegate;

+} // namespace guestview

namespace extensions {

class GuestViewManager;

@@ -16,7 +20,8 @@ class GuestViewManager;

class GuestViewManagerFactory {

public:

virtual GuestViewManager* CreateGuestViewManager(

- content::BrowserContext* context) = 0;

+ content::BrowserContext* context,

+ scoped_ptr<guestview::GuestViewManagerDelegate> delegate) = 0;

protected:

virtual ~GuestViewManagerFactory() {}