chrome/browser/signin/signin_header_helper.cc - Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_header_helper.cc

Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions_guest_view_message_filter

Patch Set: Fixed tests I hope Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/app_view_browsertest.cc ('K') | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/ui/tab_contents/core_tab_helper.cc » ('j') | extensions/browser/guest_view/guest_view_event.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_header_helper.cc

diff --git a/chrome/browser/signin/signin_header_helper.cc b/chrome/browser/signin/signin_header_helper.cc

index 03872021ed57cb923a3951d244d816fedcc58a4e..83e502b89e1ba222668f3804c4ae0aef01f26c10 100644

--- a/chrome/browser/signin/signin_header_helper.cc

+++ b/chrome/browser/signin/signin_header_helper.cc

@@ -250,7 +250,7 @@ bool AppendMirrorRequestHeaderIfPossible(

// embedded in a webui page, otherwise user may end up with a blank page as

// gaia uses the header to decide whether it returns 204 for certain end

// points.

- if (is_guest && webview_info.owner_extension_id.empty())

+ if (is_guest && webview_info.owner_host.empty())

Fady Samuel 2015/04/23 03:44:52 Note to self: Replace owner_host with is_owned_by_

Fady Samuel 2015/04/24 00:11:31 Doesn't look like this is possible because it is u

return false;

#endif // !OS_ANDROID && !OS_IOS