GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate

extensions/browser/guest_view/guest_view_manager_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_
+#define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_
+
+#include <string>
+
+namespace extensions {
+class GuestViewBase;
+}  // namespace extensions
+
+namespace guestview {
+
+// A GuestViewManagerDelegate interface allows GuestViewManager to delegate
+// responsibilities to other modules in chromium. Different builds of chromium

[lazyboy, 2015/04/22 15:16:29]

Shortly, also describe what responsibilities they are.
Explain "different builds of chromium", different platforms?

[Fady Samuel, 2015/04/22 23:09:48]

Done.

+// may use different GuestViewManagerDelegate implementations.
+class GuestViewManagerDelegate {
+ public:
+   virtual ~GuestViewManagerDelegate() {}

[lazyboy, 2015/04/22 15:16:29]

indent this file.

[Fady Samuel, 2015/04/22 23:09:48]

Done.

+
+  // Indicates whether the provided |guest| can be used in the context it has

[lazyboy, 2015/04/22 15:16:29]

nit: here and below, "the provided" is redundant since you're using |guest|
form, which already specifies which param you're talking about.

[Fady Samuel, 2015/04/22 23:09:48]

Done.

+  // been created.
+   virtual bool IsGuestAvailableToContext(extensions::GuestViewBase* guest) = 0;
+
+  // Indicates whether the provided |guest| is owned by an extension or Chrome
+  // App.
+  virtual bool IsOwnedByExtension(extensions::GuestViewBase* guest) = 0;
+
+  // Registers additional GuestView types that the GuestViewManager can create.

[lazyboy, 2015/04/22 15:16:29]

... GuestView types that our delegator (GuestViewManager) can create.

[Fady Samuel, 2015/04/22 23:09:48]

Done.

+  virtual void RegisterAdditionalGuestViewTypes() = 0;
+};
+
+}  // namespace guestview
+
+#endif  // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_DELEGATE_H_