Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: extensions/browser/guest_view/test_guest_view_manager.cc

Issue 1066563006: GuestView: Move GuestViewManager extension dependencies to ExtensionsGuestViewManagerDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensions_guest_view_message_filter
Patch Set: Fixed tests I hope Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/test_guest_view_manager.h" 5 #include "extensions/browser/guest_view/test_guest_view_manager.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "content/public/test/browser_test_utils.h" 9 #include "content/public/test/browser_test_utils.h"
10 #include "extensions/browser/app_window/app_window.h" 10 #include "extensions/browser/app_window/app_window.h"
11 #include "extensions/browser/app_window/app_window_registry.h" 11 #include "extensions/browser/app_window/app_window_registry.h"
12 #include "extensions/browser/extension_host.h" 12 #include "extensions/browser/extension_host.h"
13 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h "
13 #include "extensions/browser/process_manager.h" 14 #include "extensions/browser/process_manager.h"
14 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
15 #include "extensions/common/extension_paths.h" 16 #include "extensions/common/extension_paths.h"
16 #include "extensions/shell/browser/shell_extension_system.h" 17 #include "extensions/shell/browser/shell_extension_system.h"
17 #include "extensions/shell/test/shell_test.h" 18 #include "extensions/shell/test/shell_test.h"
18 #include "extensions/test/extension_test_message_listener.h" 19 #include "extensions/test/extension_test_message_listener.h"
19 20
21 using guestview::GuestViewManagerDelegate;
22
20 namespace extensions { 23 namespace extensions {
21 24
22 TestGuestViewManager::TestGuestViewManager(content::BrowserContext* context) 25 TestGuestViewManager::TestGuestViewManager(
23 : GuestViewManager(context) { 26 content::BrowserContext* context,
27 scoped_ptr<GuestViewManagerDelegate> delegate)
28 : GuestViewManager(context, delegate.Pass()) {
24 } 29 }
25 30
26 TestGuestViewManager::~TestGuestViewManager() { 31 TestGuestViewManager::~TestGuestViewManager() {
27 } 32 }
28 33
29 int TestGuestViewManager::GetNumGuests() const { 34 int TestGuestViewManager::GetNumGuests() const {
30 return guest_web_contents_by_instance_id_.size(); 35 return guest_web_contents_by_instance_id_.size();
31 } 36 }
32 37
33 content::WebContents* TestGuestViewManager::GetLastGuestCreated() { 38 content::WebContents* TestGuestViewManager::GetLastGuestCreated() {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 82
78 // Test factory for creating test instances of GuestViewManager. 83 // Test factory for creating test instances of GuestViewManager.
79 TestGuestViewManagerFactory::TestGuestViewManagerFactory() 84 TestGuestViewManagerFactory::TestGuestViewManagerFactory()
80 : test_guest_view_manager_(NULL) { 85 : test_guest_view_manager_(NULL) {
81 } 86 }
82 87
83 TestGuestViewManagerFactory::~TestGuestViewManagerFactory() { 88 TestGuestViewManagerFactory::~TestGuestViewManagerFactory() {
84 } 89 }
85 90
86 GuestViewManager* TestGuestViewManagerFactory::CreateGuestViewManager( 91 GuestViewManager* TestGuestViewManagerFactory::CreateGuestViewManager(
87 content::BrowserContext* context) { 92 content::BrowserContext* context,
88 return GetManager(context); 93 scoped_ptr<guestview::GuestViewManagerDelegate> delegate) {
89 } 94 if (!test_guest_view_manager_) {
90 95 test_guest_view_manager_ =
91 // This function gets called from GuestViewManager::FromBrowserContext(), 96 new TestGuestViewManager(context, delegate.Pass());
92 // where test_guest_view_manager_ is assigned to a linked_ptr that takes care 97 }
93 // of deleting it.
94 TestGuestViewManager* TestGuestViewManagerFactory::GetManager(
95 content::BrowserContext* context) {
96 DCHECK(!test_guest_view_manager_);
97 test_guest_view_manager_ = new TestGuestViewManager(context);
98 return test_guest_view_manager_; 98 return test_guest_view_manager_;
99 } 99 }
100 100
101 } // namespace extensions 101 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698