Issue 1066563002: [Extensions] Don't pass empty value to V8Converter in OnJSInjectionCompleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1066563002: [Extensions] Don't pass empty value to V8Converter in OnJSInjectionCompleted (Closed)

Created:
5 years, 8 months ago by kozy

Modified:
5 years, 8 months ago

Reviewers:
Devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Extensions] Don't pass empty value to V8Converter in OnJSInjectionCompleted There is CHECK(!val.IsEmpty()) in V8ValueConverterImpl::FromV8ValueImpl. We should call v8_converter->FromV8Value function only with not empty value. BUG=468344 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/cf33830447ca7b64617672e47933873178294578 Cr-Commit-Position: refs/heads/master@{#323909}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	extensions/renderer/script_injection.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066563002/1

5 years, 8 months ago (2015-04-06 16:20:59 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-06 17:36:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cf33830447ca7b64617672e47933873178294578
Cr-Commit-Position: refs/heads/master@{#323909}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages