Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 1066543004: Update affiliated web credentials when Android credentials are updated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the correct MessageLoopProxy occurrence this time. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_syncable_service.cc
diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc
index 870aecbbfd453f65e0477fbaedd9aa2bd34644c4..d8ced9df344485a4b03bb93ddccff5e2cbd9f7eb 100644
--- a/components/password_manager/core/browser/password_syncable_service.cc
+++ b/components/password_manager/core/browser/password_syncable_service.cc
@@ -260,6 +260,7 @@ syncer::SyncError PasswordSyncableService::ProcessSyncChanges(
AppendPasswordFromSpecifics(
specifics.password().client_only_encrypted_data(), time_now, entries);
}
+
WriteToPasswordStore(sync_entries);
return syncer::SyncError();
}
@@ -335,15 +336,12 @@ bool PasswordSyncableService::ReadFromPasswordStore(
void PasswordSyncableService::WriteToPasswordStore(const SyncEntries& entries) {
PasswordStoreChangeList changes;
- WriteEntriesToDatabase(&PasswordStoreSync::AddLoginImpl,
- entries.new_entries.get(),
- &changes);
- WriteEntriesToDatabase(&PasswordStoreSync::UpdateLoginImpl,
- entries.updated_entries.get(),
- &changes);
- WriteEntriesToDatabase(&PasswordStoreSync::RemoveLoginImpl,
- entries.deleted_entries.get(),
- &changes);
+ WriteEntriesToDatabase(&PasswordStoreSync::AddLoginSync,
+ entries.new_entries.get(), &changes);
+ WriteEntriesToDatabase(&PasswordStoreSync::UpdateLoginSync,
+ entries.updated_entries.get(), &changes);
+ WriteEntriesToDatabase(&PasswordStoreSync::RemoveLoginSync,
+ entries.deleted_entries.get(), &changes);
// We have to notify password store observers of the change by hand since
// we use internal password store interfaces to make changes synchronously.
« no previous file with comments | « components/password_manager/core/browser/password_store_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698