Update affiliated web credentials when Android credentials are updated.

components/password_manager/core/browser/password_store.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 
 #include "base/callback.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/observer_list_threadsafe.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time/time.h"
 #include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/browser/password_store_sync.h"
 #include "sync/api/syncable_service.h"
 
@@ skipping 48 matching lines @@
   virtual bool Init(const syncer::SyncableService::StartSyncFlare& flare);
 
   // Sets the affiliation-based match |helper| that will be used by subsequent
   // GetLogins() calls to return credentials stored not only for the requested
   // sign-on realm, but also for affiliated Android applications. If |helper| is
   // null, clears the the currently set helper if any. Unless a helper is set,
   // affiliation-based matching is disabled. The passed |helper| must already be
   // initialized if it is non-null.
   void SetAffiliatedMatchHelper(scoped_ptr<AffiliatedMatchHelper> helper);
 
+  // Toggles whether or not to propagate password changes in Android credentials
+  // to the affiliated Web credentials.
+  void enable_propagating_password_changes_to_web_credentials(bool enabled) {
+    is_propagating_password_changes_to_web_credentials_enabled_ = enabled;
+  }
+
   // Returns whether or not an affiliation-based match helper is set.
   bool HasAffiliatedMatchHelper() const;
 
   // Adds the given PasswordForm to the secure password store asynchronously.
   virtual void AddLogin(const autofill::PasswordForm& form);
 
   // Updates the matching PasswordForm in the secure password store (async).
   virtual void UpdateLogin(const autofill::PasswordForm& form);
 
   // Removes the matching PasswordForm from the secure password store (async).
@@ skipping 87 matching lines @@
   // Get the TaskRunner to use for PasswordStore background tasks.
   // By default, a SingleThreadTaskRunner on the DB thread is used, but
   // subclasses can override.
   virtual scoped_refptr<base::SingleThreadTaskRunner> GetBackgroundTaskRunner();
 
   // Methods below will be run in PasswordStore's own thread.
   // Synchronous implementation that reports usage metrics.
   virtual void ReportMetricsImpl(const std::string& sync_username,
                                  bool custom_passphrase_sync_enabled) = 0;
 
-  // Bring PasswordStoreSync methods to the scope of PasswordStore. Otherwise,
-  // base::Bind can't be used with them because it fails to cast PasswordStore
-  // to PasswordStoreSync.
-  PasswordStoreChangeList AddLoginImpl(
-      const autofill::PasswordForm& form) override = 0;
-  PasswordStoreChangeList UpdateLoginImpl(
-      const autofill::PasswordForm& form) override = 0;
-  PasswordStoreChangeList RemoveLoginImpl(
-      const autofill::PasswordForm& form) override = 0;
-
   // Synchronous implementation to remove the given logins.
   virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
       base::Time delete_begin,
       base::Time delete_end) = 0;
 
   // Synchronous implementation to remove the given logins.
   virtual PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
       base::Time delete_begin,
       base::Time delete_end) = 0;
 
   // Finds all PasswordForms with a signon_realm that is equal to, or is a
   // PSL-match to that of |form|, and takes care of notifying the consumer with
   // the results when done.
   // Note: subclasses should implement FillMatchingLogins() instead. This needs
   // to be virtual only because asynchronous behavior in PasswordStoreWin.
   // TODO(engedy): Make this non-virtual once https://crbug.com/78830 is fixed.
   virtual void GetLoginsImpl(const autofill::PasswordForm& form,
                              AuthorizationPromptPolicy prompt_policy,
                              scoped_ptr<GetLoginsRequest> request);
 
+  // Synchronous implementation provided by subclasses to add the given login.
+  virtual PasswordStoreChangeList AddLoginImpl(
+      const autofill::PasswordForm& form) = 0;
+
+  // Synchronous implementation provided by subclasses to update the given
+  // login.
+  virtual PasswordStoreChangeList UpdateLoginImpl(
+      const autofill::PasswordForm& form) = 0;
+
+  // Synchronous implementation provided by subclasses to remove the given
+  // login.
+  virtual PasswordStoreChangeList RemoveLoginImpl(
+      const autofill::PasswordForm& form) = 0;
+
   // Finds and returns all PasswordForms with the same signon_realm as |form|,
   // or with a signon_realm that is a PSL-match to that of |form|.
   virtual ScopedVector<autofill::PasswordForm> FillMatchingLogins(
       const autofill::PasswordForm& form,
       AuthorizationPromptPolicy prompt_policy) = 0;
 
   // Finds all non-blacklist PasswordForms, and notifies the consumer.
   virtual void GetAutofillableLoginsImpl(
       scoped_ptr<GetLoginsRequest> request) = 0;
 
   // Finds all blacklist PasswordForms, and notifies the consumer.
   virtual void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request) = 0;
 
   // Log UMA stats for number of bulk deletions.
   void LogStatsForBulkDeletion(int num_deletions);
 
   // Log UMA stats for password deletions happening on clear browsing data
   // since first sync during rollback.
   void LogStatsForBulkDeletionDuringRollback(int num_deletions);
 
   // PasswordStoreSync:
+  PasswordStoreChangeList AddLoginSync(
+      const autofill::PasswordForm& form) override;
+  PasswordStoreChangeList UpdateLoginSync(
+      const autofill::PasswordForm& form) override;
+  PasswordStoreChangeList RemoveLoginSync(
+      const autofill::PasswordForm& form) override;
+
   // Called by WrapModificationTask() once the underlying data-modifying
   // operation has been performed. Notifies observers that password store data
   // may have been changed.
   void NotifyLoginsChanged(const PasswordStoreChangeList& changes) override;
 
   // TaskRunner for tasks that run on the main thread (usually the UI thread).
   scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner_;
 
   // TaskRunner for the DB thread. By default, this is the task runner used for
   // background tasks -- see |GetBackgroundTaskRunner|.
   scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner_;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(PasswordStoreTest, GetLoginImpl);
+  FRIEND_TEST_ALL_PREFIXES(PasswordStoreTest,
+                           UpdatePasswordsStoredForAffiliatedWebsites);
+
   // Schedule the given |func| to be run in the PasswordStore's own thread with
   // responses delivered to |consumer| on the current thread.
   void Schedule(void (PasswordStore::*func)(scoped_ptr<GetLoginsRequest>),
                 PasswordStoreConsumer* consumer);
 
   // Wrapper method called on the destination thread (DB for non-mac) that
   // invokes |task| and then calls back into the source thread to notify
   // observers that the password store may have been modified via
   // NotifyLoginsChanged(). Note that there is no guarantee that the called
   // method will actually modify the password store data.
@@ skipping 21 matching lines @@
       scoped_ptr<GetLoginsRequest> request,
       const std::vector<std::string>& additional_android_realms);
 
   // Schedules GetLoginsWithAffiliationsImpl() to be run on the DB thread.
   void ScheduleGetLoginsWithAffiliations(
       const autofill::PasswordForm& form,
       AuthorizationPromptPolicy prompt_policy,
       scoped_ptr<GetLoginsRequest> request,
       const std::vector<std::string>& additional_android_realms);
 
+  // Retrieves the currently stored form, if any, with the same primary key as
+  // |form|, that is, with the same signon_realm, origin, username_element,
+  // username_value and password_element attributes.
+  scoped_ptr<autofill::PasswordForm> GetLoginImpl(

[vasilii, 2015/04/21 09:20:18]

For these functions mention the thread they are executed on.

[engedy, 2015/04/21 09:42:25]

Done.

+      const autofill::PasswordForm& primary_key);
+
+  // Called when a password is added or updated for an Android application, and
+  // triggers finding web sites affiliated with the Android application and
+  // propagating the new password to credentials for those web sites, if any.
+  void FindAndUpdateAffiliatedWebLogins(
+      const autofill::PasswordForm& added_or_updated_android_form);
+
+  // Posts FindAndUpdateAffiliatedWebLogins() to the main thread.
+  void ScheduleFindAndUpdateAffiliatedWebLogins(
+      const autofill::PasswordForm& added_or_updated_android_form);
+
+  // Called when a password is added or updated for an Android application, and
+  // propagates these changes to credentials stored for |affiliated_web_realms|
+  // under the same username, if there are any.
+  void UpdateAffiliatedWebLoginsImpl(
+      const autofill::PasswordForm& updated_android_form,
+      const std::vector<std::string>& affiliated_web_realms);
+
+  // Schedules UpdateAffiliatedWebLoginsImpl() to run on the DB thread.
+  void ScheduleUpdateAffiliatedWebLoginsImpl(
+      const autofill::PasswordForm& updated_android_form,
+      const std::vector<std::string>& affiliated_web_realms);
+
   // Creates PasswordSyncableService instance on the background thread.
   void InitSyncableService(
       const syncer::SyncableService::StartSyncFlare& flare);
 
   // Deletes PasswordSyncableService instance on the background thread.
   void DestroySyncableService();
 
   // The observers.
   scoped_refptr<ObserverListThreadSafe<Observer>> observers_;
 
   scoped_ptr<PasswordSyncableService> syncable_service_;
   scoped_ptr<AffiliatedMatchHelper> affiliated_match_helper_;
+  bool is_propagating_password_changes_to_web_credentials_enabled_;
 
   bool shutdown_called_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStore);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_