Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1066523002: Cleanup: Remove basictypes.h includes from seccomp-bpf. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, viettrungluu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove basictypes.h includes from seccomp-bpf. Tested on Linux with the following command lines: $ rm -rf out/ $ ./build/gyp_chromium $ ninja -C out/Debug sandbox_linux_unittests $ out/Debug/sandbox_linux_unittests BUG=138542 TEST=see above R=mdempsky@chromium.org,jln@chromium.org Committed: https://crrev.com/6f766eb6efd7ba2e8aaa0efe709d93374c2f70f8 Cr-Commit-Position: refs/heads/master@{#323914}

Patch Set 1 #

Total comments: 2

Patch Set 2 : stdint.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sandbox/linux/seccomp-bpf/syscall.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
Very trivial. ptal
5 years, 8 months ago (2015-04-05 18:44:39 UTC) #1
jln (very slow on Chromium)
https://codereview.chromium.org/1066523002/diff/1/sandbox/linux/seccomp-bpf/syscall.cc File sandbox/linux/seccomp-bpf/syscall.cc (left): https://codereview.chromium.org/1066523002/diff/1/sandbox/linux/seccomp-bpf/syscall.cc#oldcode10 sandbox/linux/seccomp-bpf/syscall.cc:10: #include "base/basictypes.h" We would need <stdint> for intptr_t then. ...
5 years, 8 months ago (2015-04-06 16:35:43 UTC) #3
jln (very slow on Chromium)
Just read the bug: lgtm, but please include <stdint.h>
5 years, 8 months ago (2015-04-06 16:36:45 UTC) #4
tfarina
https://codereview.chromium.org/1066523002/diff/1/sandbox/linux/seccomp-bpf/syscall.cc File sandbox/linux/seccomp-bpf/syscall.cc (left): https://codereview.chromium.org/1066523002/diff/1/sandbox/linux/seccomp-bpf/syscall.cc#oldcode10 sandbox/linux/seccomp-bpf/syscall.cc:10: #include "base/basictypes.h" On 2015/04/06 16:35:43, jln wrote: > We ...
5 years, 8 months ago (2015-04-06 16:51:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066523002/20001
5 years, 8 months ago (2015-04-06 16:51:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 18:27:38 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 18:30:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f766eb6efd7ba2e8aaa0efe709d93374c2f70f8
Cr-Commit-Position: refs/heads/master@{#323914}

Powered by Google App Engine
This is Rietveld 408576698