gpu: Log a failure in GLImageEGL::Destroy()

ui/gl/gl_image_egl.cc

Index: ui/gl/gl_image_egl.cc
diff --git a/ui/gl/gl_image_egl.cc b/ui/gl/gl_image_egl.cc
index b8ee78c3a371575a33b9bbb8fa4d02678bf01333..9f90a16bcaedcde434742d7aa0b26dcbdc126768 100644
--- a/ui/gl/gl_image_egl.cc
+++ b/ui/gl/gl_image_egl.cc
@@ -27,7 +27,7 @@ bool GLImageEGL::Initialize(EGLenum target,
                                  attrs);
   if (egl_image_ == EGL_NO_IMAGE_KHR) {
     EGLint error = eglGetError();

[reveman, 2015/04/07 13:36:52]

nit: This call to eglGetError() will be unnecessary if DLOG is disabled. Please
remove this temporary variable and use eglGetError() directly in the DLOG
statement below instead. 

[dshwang, 2015/04/07 14:44:50]

Done.

-    LOG(ERROR) << "Error creating EGLImage: " << error;
+    DLOG(ERROR) << "Error creating EGLImage: " << error;
     return false;
   }
 
@@ -36,8 +36,13 @@ bool GLImageEGL::Initialize(EGLenum target,
 
 void GLImageEGL::Destroy(bool have_context) {
   if (egl_image_ != EGL_NO_IMAGE_KHR) {
-    eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image_);
+    bool result =

[reveman, 2015/04/07 13:36:52]

nit: is "bool" really the correct return type? if you like, you can skip this
temporary variable and just put eglDestroyImageKHR in the if statement

[dshwang, 2015/04/07 14:44:50]

Done.

+        eglDestroyImageKHR(GLSurfaceEGL::GetHardwareDisplay(), egl_image_);
     egl_image_ = EGL_NO_IMAGE_KHR;

[reveman, 2015/04/07 13:36:52]

nit: I prefer if you reset egl_image_ below the error check instead of in the
middle here

[dshwang, 2015/04/07 14:44:50]

Done.

+    if (result == EGL_FALSE) {
+      EGLint error = eglGetError();

[reveman, 2015/04/07 13:36:52]

nit: unnecessary call to eglGetError() if DLOG is disabled.

[dshwang, 2015/04/07 14:44:50]

Done.

+      DLOG(ERROR) << "Error destroying EGLImage: " << error;
+    }
   }
 }