gpu: Log a failure in GLImageEGL::Destroy()

gpu: Log a failure in GLImageEGL::Destroy()

Committed: https://crrev.com/66411d520b55d8496628d6394ec3eeae8ed1dad2
Cr-Commit-Position: refs/heads/master@{#324047}

[dshwang, 2015-04-07 05:47:20]

dongseong.hwang@intel.com changed reviewers:
+ reveman@chromium.org

[dshwang, 2015-04-07 05:47:20]

reveman@, could you review this small change?

[reveman, 2015-04-07 13:36:52]

lgtm with nits

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc
File ui/gl/gl_image_egl.cc (right):

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:29: EGLint error = eglGetError();
nit: This call to eglGetError() will be unnecessary if DLOG is disabled. Please
remove this temporary variable and use eglGetError() directly in the DLOG
statement below instead.

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:39: bool result =
nit: is "bool" really the correct return type? if you like, you can skip this
temporary variable and just put eglDestroyImageKHR in the if statement

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:41: egl_image_ = EGL_NO_IMAGE_KHR;
nit: I prefer if you reset egl_image_ below the error check instead of in the
middle here

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:43: EGLint error = eglGetError();
nit: unnecessary call to eglGetError() if DLOG is disabled.

[dshwang, 2015-04-07 14:44:50]

Thanks you for reviewing and comment for every lines!

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc
File ui/gl/gl_image_egl.cc (right):

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:29: EGLint error = eglGetError();
On 2015/04/07 13:36:52, reveman wrote:
> nit: This call to eglGetError() will be unnecessary if DLOG is disabled.
Please
> remove this temporary variable and use eglGetError() directly in the DLOG
> statement below instead. 

Done.

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:39: bool result =
On 2015/04/07 13:36:52, reveman wrote:
> nit: is "bool" really the correct return type? if you like, you can skip this
> temporary variable and just put eglDestroyImageKHR in the if statement

Done.

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:41: egl_image_ = EGL_NO_IMAGE_KHR;
On 2015/04/07 13:36:52, reveman wrote:
> nit: I prefer if you reset egl_image_ below the error check instead of in the
> middle here

Done.

https://codereview.chromium.org/1066483003/diff/1/ui/gl/gl_image_egl.cc#newco...
ui/gl/gl_image_egl.cc:43: EGLint error = eglGetError();
On 2015/04/07 13:36:52, reveman wrote:
> nit: unnecessary call to eglGetError() if DLOG is disabled.

Done.

[dshwang, 2015-04-07 14:45:10]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2015-04-07 14:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1066483003/#ps20001
(title: "address nits")

[commit-bot: I haz the power, 2015-04-07 14:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066483003/20001

[commit-bot: I haz the power, 2015-04-07 15:29:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 15:30:33]

Patchset 2 (id:??) landed as
https://crrev.com/66411d520b55d8496628d6394ec3eeae8ed1dad2
Cr-Commit-Position: refs/heads/master@{#324047}